Merge pull request #43091 from tienifr/fix/42821

fix Keyboard opens and closes when tapping on split input
Expensify · Jun 7, 2024 · cb4715f · cb4715f
2 parents c056692 + 51a0e4a
commit cb4715f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/src/components/MoneyRequestConfirmationList.tsx b/src/components/MoneyRequestConfirmationList.tsx
@@ -1280,6 +1280,7 @@ function MoneyRequestConfirmationList({
                 footerContent={footerContent}
                 listFooterContent={listFooterContent}
                 containerStyle={[styles.flexBasisAuto]}
+                removeClippedSubviews={false}
             />
         </MouseProvider>
     );

diff --git a/src/components/SectionList/index.android.tsx b/src/components/SectionList/index.android.tsx
@@ -11,7 +11,7 @@ function SectionListWithRef<ItemT, SectionT>(props: SectionListProps<ItemT, Sect
             // For Android we want to use removeClippedSubviews since it helps manage memory consumption. When we
             // run out memory images stop loading and appear as grey circles
             // eslint-disable-next-line react/jsx-props-no-multi-spaces
-            removeClippedSubviews
+            removeClippedSubviews={props.removeClippedSubviews ?? true}
         />
     );
 }

diff --git a/src/components/SelectionList/BaseSelectionList.tsx b/src/components/SelectionList/BaseSelectionList.tsx
@@ -85,6 +85,7 @@ function BaseSelectionList<TItem extends ListItem>(
         onEndReachedThreshold,
         windowSize = 5,
         updateCellsBatchingPeriod = 50,
+        removeClippedSubviews = true,
     }: BaseSelectionListProps<TItem>,
     ref: ForwardedRef<SelectionListHandle>,
 ) {
@@ -677,6 +678,7 @@ function BaseSelectionList<TItem extends ListItem>(
                         <>
                             {!listHeaderContent && header()}
                             <SectionList
+                                removeClippedSubviews={removeClippedSubviews}
                                 ref={listRef}
                                 sections={slicedSections}
                                 stickySectionHeadersEnabled={false}

diff --git a/src/components/SelectionList/types.ts b/src/components/SelectionList/types.ts
@@ -398,6 +398,9 @@ type BaseSelectionListProps<TItem extends ListItem> = Partial<ChildrenProps> & {
     /** Styles for the section title */
     sectionTitleStyles?: StyleProp<ViewStyle>;
 
+    /** This may improve scroll performance for large lists */
+    removeClippedSubviews?: boolean;
+
     /**
      * When true, the list won't be visible until the list layout is measured. This prevents the list from "blinking" as it's scrolled to the bottom which is recommended for large lists.
      * When false, the list will render immediately and scroll to the bottom which works great for small lists.