Merge pull request #51724 from mkzie2/mkzie2-issue/50572

fix: sound plays before paying held expense report
Expensify · Nov 15, 2024 · ce90360 · ce90360
2 parents 902c4e3 + 8206ad0
commit ce90360
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/components/ProcessMoneyReportHoldMenu.tsx b/src/components/ProcessMoneyReportHoldMenu.tsx
@@ -4,6 +4,7 @@ import useLocalize from '@hooks/useLocalize';
 import useResponsiveLayout from '@hooks/useResponsiveLayout';
 import Navigation from '@libs/Navigation/Navigation';
 import {isLinkedTransactionHeld} from '@libs/ReportActionsUtils';
+import playSound, {SOUNDS} from '@libs/Sound';
 import * as IOU from '@userActions/IOU';
 import CONST from '@src/CONST';
 import ROUTES from '@src/ROUTES';
@@ -74,6 +75,7 @@ function ProcessMoneyReportHoldMenu({
             if (startAnimation) {
                 startAnimation();
             }
+            playSound(SOUNDS.SUCCESS);
             IOU.payMoneyRequest(paymentType, chatReport, moneyRequestReport, full);
         }
         onClose();

diff --git a/src/components/SettlementButton/index.tsx b/src/components/SettlementButton/index.tsx
@@ -213,7 +213,9 @@ function SettlementButton({
             return;
         }
 
-        playSound(SOUNDS.SUCCESS);
+        if (!ReportUtils.hasHeldExpenses(iouReport?.reportID)) {
+            playSound(SOUNDS.SUCCESS);
+        }
         onPress(iouPaymentType);
     };