Merge pull request #43516 from Expensify/andrew-release

Use gh cli for production deploy
Expensify · Jun 12, 2024 · d1d9dfa · d1d9dfa
2 parents 9376991 + 1ead9e7
commit d1d9dfa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -14,7 +14,7 @@ jobs:
         with:
           ref: staging
           token: ${{ secrets.OS_BOTIFY_TOKEN }}
-          
+
       - name: Setup git for OSBotify
         uses: ./.github/actions/composite/setupGitForOSBotifyApp
         id: setupGitForOSBotify
@@ -65,9 +65,6 @@ jobs:
           PR_LIST: ${{ steps.getReleasePRList.outputs.PR_LIST }}
 
       - name: 🚀 Create release to trigger production deploy 🚀
-        uses: softprops/action-gh-release@affa18ef97bc9db20076945705aba8c516139abd
-        with:
-          tag_name: ${{ env.PRODUCTION_VERSION }}
-          body: ${{ steps.getReleaseBody.outputs.RELEASE_BODY }}
+        run: gh release create ${{ env.PRODUCTION_VERSION }} --notes ${{ steps.getReleaseBody.outputs.RELEASE_BODY }}
         env:
           GITHUB_TOKEN: ${{ steps.setupGitForOSBotify.outputs.OS_BOTIFY_API_TOKEN }}
diff --git a/workflow_tests/assertions/deployAssertions.ts b/workflow_tests/assertions/deployAssertions.ts
@@ -49,10 +49,7 @@ function assertDeployProductionJobExecuted(workflowResult: Step[], didExecute =
             null,
             'DEPLOY_PRODUCTION',
             'Creating release to trigger production deploy',
-            [
-                {key: 'tag_name', value: '1.2.3'},
-                {key: 'body', value: 'Release body'},
-            ],
+            [],
             [{key: 'GITHUB_TOKEN', value: 'os_botify_api_token'}],
         ),
     ] as const;

diff --git a/workflow_tests/mocks/deployMocks.ts b/workflow_tests/mocks/deployMocks.ts
@@ -44,7 +44,7 @@ const DEPLOY_PRODUCTION__CREATE_RELEASE__STEP_MOCK = createMockStep(
     '🚀 Create release to trigger production deploy 🚀',
     'Creating release to trigger production deploy',
     'DEPLOY_PRODUCTION',
-    ['tag_name', 'body'],
+    [],
     ['GITHUB_TOKEN'],
 );
 const DEPLOY_PRODUCTION_STEP_MOCKS = [