From 752d5ee457855db0167fbc9ba5c010d1aa378d7b Mon Sep 17 00:00:00 2001 From: Getabalew Tesfaye Date: Mon, 9 Oct 2023 23:07:08 +0300 Subject: [PATCH 1/3] fix cursor inconsistency --- docs/_sass/_search-bar.scss | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/_sass/_search-bar.scss b/docs/_sass/_search-bar.scss index a5cc8ae2ff20..bdb5986cc07e 100644 --- a/docs/_sass/_search-bar.scss +++ b/docs/_sass/_search-bar.scss @@ -88,11 +88,14 @@ $color-gray-label: $color-gray-label; /* All gsc id & class are Google Search relate gcse_0 is the search bar parent & gcse_1 is the search result list parent */ #___gcse_0 { margin-left: 20px; + margin-top: -8px; } /* This input is in #___gcse_0 search bar */ input#gsc-i-id1.gsc-input { background-color: $color-appBG; + padding: 15px 0px 0px !important; + height: 1.40em !important; color: #E7ECE9; font-family: "ExpensifyNeue", "Segoe UI Emoji", "Noto Color Emoji" !important; } @@ -109,7 +112,7 @@ input#gsc-i-id1.gsc-input { } .gsc-input-box .gsib_a { - padding: 5px 9px 4px 0px; + padding: 0px 9px 4px 0px; } .search-icon { @@ -148,6 +151,7 @@ label.search-label { font-family: "ExpensifyNeue", "Segoe UI Emoji", "Noto Color Emoji"; transform: translateY(-50%); left: 20px; + pointer-events: none; color: $color-gray-label; transform-origin: left top; user-select: none; @@ -181,7 +185,6 @@ label.search-label { /* Change the Google Search Button icon into Expensify icon button */ .gsc-search-button.gsc-search-button-v2 { padding: 10px; - margin-top: -7px; margin-left: 15px; margin-right: 20px; border-radius: 25px; From 51823ff820cce1753320669b61c14220f48a8015 Mon Sep 17 00:00:00 2001 From: Getabalew Tesfaye Date: Mon, 9 Oct 2023 23:52:03 +0300 Subject: [PATCH 2/3] match stylings with previous style --- docs/_sass/_search-bar.scss | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/_sass/_search-bar.scss b/docs/_sass/_search-bar.scss index bdb5986cc07e..377d72bd28e9 100644 --- a/docs/_sass/_search-bar.scss +++ b/docs/_sass/_search-bar.scss @@ -95,7 +95,6 @@ $color-gray-label: $color-gray-label; input#gsc-i-id1.gsc-input { background-color: $color-appBG; padding: 15px 0px 0px !important; - height: 1.40em !important; color: #E7ECE9; font-family: "ExpensifyNeue", "Segoe UI Emoji", "Noto Color Emoji" !important; } @@ -112,16 +111,21 @@ input#gsc-i-id1.gsc-input { } .gsc-input-box .gsib_a { - padding: 0px 9px 4px 0px; + padding: 0px 0px 4px 0px; } .search-icon { margin-left: auto; } +.gsst_b { + padding: 0px !important; +} /* This is the close icon on search bar */ .gsib_b .gsst_a .gscb_a { color: $color-icons; + margin-top: 8px; + padding: 0 2px !important; &:hover { color: $color-text; From 092527a983fff99b250d999c6fe6de721771a5f2 Mon Sep 17 00:00:00 2001 From: Getabalew Tesfaye Date: Tue, 10 Oct 2023 21:25:24 +0300 Subject: [PATCH 3/3] fix further cursor inconsistencies and a flicker on border click --- docs/_sass/_search-bar.scss | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/docs/_sass/_search-bar.scss b/docs/_sass/_search-bar.scss index 377d72bd28e9..e9c56835af50 100644 --- a/docs/_sass/_search-bar.scss +++ b/docs/_sass/_search-bar.scss @@ -95,6 +95,7 @@ $color-gray-label: $color-gray-label; input#gsc-i-id1.gsc-input { background-color: $color-appBG; padding: 15px 0px 0px !important; + pointer-events: auto; color: #E7ECE9; font-family: "ExpensifyNeue", "Segoe UI Emoji", "Noto Color Emoji" !important; } @@ -104,7 +105,8 @@ input#gsc-i-id1.gsc-input { background-color: $color-appBG; border-bottom: $color-borders 2px solid; border-bottom-left-radius: 0px; - + pointer-events: none; + &:focus-within { border-bottom: $color-accent 2px solid; } @@ -118,14 +120,14 @@ input#gsc-i-id1.gsc-input { margin-left: auto; } -.gsst_b { +.gsst_b, .gsst_a { padding: 0px !important; } /* This is the close icon on search bar */ .gsib_b .gsst_a .gscb_a { color: $color-icons; - margin-top: 8px; - padding: 0 2px !important; + padding: 8px 6px 0px 6px !important; + pointer-events: auto; &:hover { color: $color-text;