From 95f432f162593cae937504f15ebc9f925558b3e8 Mon Sep 17 00:00:00 2001 From: codinggeek2023 Date: Fri, 23 Feb 2024 00:20:36 +0530 Subject: [PATCH 1/5] Change finish to stop to avoid confusion --- src/components/DistanceEReceipt.tsx | 2 -- src/components/DistanceRequest/DistanceRequestRenderItem.tsx | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/components/DistanceEReceipt.tsx b/src/components/DistanceEReceipt.tsx index 9846cfa04257..941d63c1bf94 100644 --- a/src/components/DistanceEReceipt.tsx +++ b/src/components/DistanceEReceipt.tsx @@ -75,8 +75,6 @@ function DistanceEReceipt({transaction}: DistanceEReceiptProps) { let descriptionKey: TranslationPaths = 'distance.waypointDescription.stop'; if (index === 0) { descriptionKey = 'distance.waypointDescription.start'; - } else if (index === Object.keys(waypoints).length - 1) { - descriptionKey = 'distance.waypointDescription.finish'; } return ( diff --git a/src/components/DistanceRequest/DistanceRequestRenderItem.tsx b/src/components/DistanceRequest/DistanceRequestRenderItem.tsx index a1f3efbf0291..57e4fb0b530e 100644 --- a/src/components/DistanceRequest/DistanceRequestRenderItem.tsx +++ b/src/components/DistanceRequest/DistanceRequestRenderItem.tsx @@ -42,7 +42,7 @@ function DistanceRequestRenderItem({waypoints, item = '', onSecondaryInteraction descriptionKey += 'start'; waypointIcon = Expensicons.DotIndicatorUnfilled; } else if (index === lastWaypointIndex) { - descriptionKey += 'finish'; + descriptionKey += 'stop'; waypointIcon = Expensicons.Location; } else { descriptionKey += 'stop'; From b120f487f6b5e0f33301dfdf0aaf953abf6de0af Mon Sep 17 00:00:00 2001 From: Riya Shete <156463907+codinggeek2023@users.noreply.github.com> Date: Wed, 28 Feb 2024 00:56:55 +0530 Subject: [PATCH 2/5] Update en.ts --- src/languages/en.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/languages/en.ts b/src/languages/en.ts index b6a24f33035c..a645c977a473 100755 --- a/src/languages/en.ts +++ b/src/languages/en.ts @@ -2206,7 +2206,6 @@ export default { address: 'Address', waypointDescription: { start: 'Start', - finish: 'Finish', stop: 'Stop', }, mapPending: { From 56ab70862ec2a6d2c3fcd11e188d7ef6266dd421 Mon Sep 17 00:00:00 2001 From: Riya Shete <156463907+codinggeek2023@users.noreply.github.com> Date: Wed, 28 Feb 2024 00:57:58 +0530 Subject: [PATCH 3/5] Update IOURequestStepWaypoint.tsx --- src/pages/iou/request/step/IOURequestStepWaypoint.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/pages/iou/request/step/IOURequestStepWaypoint.tsx b/src/pages/iou/request/step/IOURequestStepWaypoint.tsx index eee6da9e87ef..c4e27d52e09f 100644 --- a/src/pages/iou/request/step/IOURequestStepWaypoint.tsx +++ b/src/pages/iou/request/step/IOURequestStepWaypoint.tsx @@ -82,8 +82,6 @@ function IOURequestStepWaypoint({ switch (parsedWaypointIndex) { case 0: return 'distance.waypointDescription.start'; - case waypointCount - 1: - return 'distance.waypointDescription.finish'; default: return 'distance.waypointDescription.stop'; } From f5963cae18f1277ed95884b4db1d673f9068360c Mon Sep 17 00:00:00 2001 From: Riya Shete <156463907+codinggeek2023@users.noreply.github.com> Date: Wed, 28 Feb 2024 01:01:36 +0530 Subject: [PATCH 4/5] Update es.ts --- src/languages/es.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/languages/es.ts b/src/languages/es.ts index c9ff087d0de7..da30eb01e84d 100644 --- a/src/languages/es.ts +++ b/src/languages/es.ts @@ -2725,7 +2725,6 @@ export default { address: 'Dirección', waypointDescription: { start: 'Comienzo', - finish: 'Final', stop: 'Parada', }, mapPending: { From f92b845aff8c030b2a3fd2c76c69d9e06bf101c8 Mon Sep 17 00:00:00 2001 From: Riya Shete <156463907+codinggeek2023@users.noreply.github.com> Date: Wed, 28 Feb 2024 01:06:27 +0530 Subject: [PATCH 5/5] fix lint --- src/pages/iou/request/step/IOURequestStepWaypoint.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/iou/request/step/IOURequestStepWaypoint.tsx b/src/pages/iou/request/step/IOURequestStepWaypoint.tsx index c4e27d52e09f..5a68c85546e6 100644 --- a/src/pages/iou/request/step/IOURequestStepWaypoint.tsx +++ b/src/pages/iou/request/step/IOURequestStepWaypoint.tsx @@ -85,7 +85,7 @@ function IOURequestStepWaypoint({ default: return 'distance.waypointDescription.stop'; } - }, [parsedWaypointIndex, waypointCount]); + }, [parsedWaypointIndex]); const locationBias = useLocationBias(allWaypoints, userLocation); const waypointAddress = currentWaypoint.address ?? '';