Skip to content

Commit

Permalink
Merge pull request #40196 from Expensify/hayata-fix-param-type
Browse files Browse the repository at this point in the history
Fix param type
  • Loading branch information
srikarparsi authored Apr 12, 2024
2 parents 6600b4c + a1ce2b8 commit dcee26b
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
11 changes: 5 additions & 6 deletions src/libs/API/parameters/UpdatePolicyConnectionConfigParams.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import type {ValueOf} from 'type-fest';
import type CONST from '@src/CONST';
import type {ConnectionName, Connections} from '@src/types/onyx/Policy';

type UpdatePolicyConnectionConfigParams = {
type UpdatePolicyConnectionConfigParams<TConnectionName extends ConnectionName, TSettingName extends keyof Connections[TConnectionName]['config']> = {
policyID: string;
connectionName: string;
settingName: ValueOf<typeof CONST.QUICK_BOOKS_IMPORTS>;
settingValue: ValueOf<typeof CONST.INTEGRATION_ENTITY_MAP_TYPES>;
connectionName: TConnectionName;
settingName: TSettingName;
settingValue: Connections[TConnectionName]['config'][TSettingName];
idempotencyKey: string;
};

Expand Down
3 changes: 2 additions & 1 deletion src/libs/API/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,8 @@ type WriteCommandParameters = {
[WRITE_COMMANDS.RENAME_POLICY_TAX]: Parameters.RenamePolicyTaxParams;
[WRITE_COMMANDS.SET_POLICY_DISTANCE_RATES_UNIT]: Parameters.SetPolicyDistanceRatesUnitParams;
[WRITE_COMMANDS.SET_POLICY_DISTANCE_RATES_DEFAULT_CATEGORY]: Parameters.SetPolicyDistanceRatesDefaultCategoryParams;
[WRITE_COMMANDS.UPDATE_POLICY_CONNECTION_CONFIG]: Parameters.UpdatePolicyConnectionConfigParams;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
[WRITE_COMMANDS.UPDATE_POLICY_CONNECTION_CONFIG]: Parameters.UpdatePolicyConnectionConfigParams<any, any>;
[WRITE_COMMANDS.UPDATE_POLICY_DISTANCE_RATE_VALUE]: Parameters.UpdatePolicyDistanceRateValueParams;
[WRITE_COMMANDS.SET_POLICY_DISTANCE_RATES_ENABLED]: Parameters.SetPolicyDistanceRatesEnabledParams;
[WRITE_COMMANDS.DELETE_POLICY_DISTANCE_RATES]: Parameters.DeletePolicyDistanceRatesParams;
Expand Down
4 changes: 4 additions & 0 deletions src/types/onyx/Policy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,8 @@ type Connections = {
quickbooksOnline: Connection<QBOConnectionData, QBOConnectionConfig>;
};

type ConnectionName = keyof Connections;

type ACHAccount = {
bankAccountID: number;
accountNumber: string;
Expand Down Expand Up @@ -466,4 +468,6 @@ export type {
PendingJoinRequestPolicy,
PolicyConnectionSyncStage,
PolicyConnectionSyncProgress,
Connections,
ConnectionName,
};

0 comments on commit dcee26b

Please sign in to comment.