Skip to content

Commit

Permalink
Merge pull request #28794 from cubuspl42/revert-pr-28583
Browse files Browse the repository at this point in the history
Revert "Handle suggestions only on selection change"
  • Loading branch information
Julesssss authored Oct 4, 2023
2 parents a65e62a + 89ac222 commit df0cc2a
Showing 1 changed file with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -234,10 +234,7 @@ function SuggestionMention({

useEffect(() => {
calculateMentionSuggestion(selection.end);

// We want this hook to run only on selection change.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [selection]);
}, [selection, calculateMentionSuggestion]);

const updateShouldShowSuggestionMenuToFalse = useCallback(() => {
setSuggestionValues((prevState) => {
Expand Down

0 comments on commit df0cc2a

Please sign in to comment.