From 34a2fdb7c5c1cb394513c73452de9c1a544a6e89 Mon Sep 17 00:00:00 2001 From: Marc Glasser Date: Tue, 5 Sep 2023 11:20:59 -1000 Subject: [PATCH 1/4] Add a log for Doza so that we can try to figure out why he is hitting this code --- src/libs/actions/App.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libs/actions/App.js b/src/libs/actions/App.js index 6028e0468696..30553bf50964 100644 --- a/src/libs/actions/App.js +++ b/src/libs/actions/App.js @@ -453,6 +453,11 @@ function beginDeepLinkRedirect(shouldAuthenticateWithCurrentAccount = true) { // eslint-disable-next-line rulesdir/no-api-side-effects-method API.makeRequestWithSideEffects('OpenOldDotLink', {shouldRetry: false}, {}).then((response) => { + if (!response) { + Log.alert('Trying to redirect via deep link, but the response is empty', {response}, true); + return; + } + Browser.openRouteInDesktopApp(response.shortLivedAuthToken, currentUserEmail); }); } From c5cc1c80b35f0760003a3b4b01d969d6e66dad4c Mon Sep 17 00:00:00 2001 From: Marc Glasser Date: Tue, 5 Sep 2023 15:59:45 -1000 Subject: [PATCH 2/4] add more params --- src/libs/actions/App.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/actions/App.js b/src/libs/actions/App.js index 30553bf50964..64785e98d5c0 100644 --- a/src/libs/actions/App.js +++ b/src/libs/actions/App.js @@ -454,7 +454,7 @@ function beginDeepLinkRedirect(shouldAuthenticateWithCurrentAccount = true) { // eslint-disable-next-line rulesdir/no-api-side-effects-method API.makeRequestWithSideEffects('OpenOldDotLink', {shouldRetry: false}, {}).then((response) => { if (!response) { - Log.alert('Trying to redirect via deep link, but the response is empty', {response}, true); + Log.alert('Trying to redirect via deep link, but the response is empty', {response, shouldAuthenticateWithCurrentAccount, currentUserAccountID}, true); return; } From e4d3e4a0edcabe9e21482455dfde8c42f4337530 Mon Sep 17 00:00:00 2001 From: Marc Glasser Date: Tue, 5 Sep 2023 16:10:30 -1000 Subject: [PATCH 3/4] Add more to the comment --- src/libs/actions/App.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/actions/App.js b/src/libs/actions/App.js index 64785e98d5c0..e77fb98c2826 100644 --- a/src/libs/actions/App.js +++ b/src/libs/actions/App.js @@ -454,7 +454,7 @@ function beginDeepLinkRedirect(shouldAuthenticateWithCurrentAccount = true) { // eslint-disable-next-line rulesdir/no-api-side-effects-method API.makeRequestWithSideEffects('OpenOldDotLink', {shouldRetry: false}, {}).then((response) => { if (!response) { - Log.alert('Trying to redirect via deep link, but the response is empty', {response, shouldAuthenticateWithCurrentAccount, currentUserAccountID}, true); + Log.alert('Trying to redirect via deep link, but the response is empty. User likely not authenticated.', {response, shouldAuthenticateWithCurrentAccount, currentUserAccountID}, true); return; } From 58efdcb7debde46d4a239cd6b5a08edc8e8b7460 Mon Sep 17 00:00:00 2001 From: Marc Glasser Date: Wed, 6 Sep 2023 08:20:52 -1000 Subject: [PATCH 4/4] run prettier --- src/libs/actions/App.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/libs/actions/App.js b/src/libs/actions/App.js index e77fb98c2826..3d0d7d27c204 100644 --- a/src/libs/actions/App.js +++ b/src/libs/actions/App.js @@ -454,7 +454,11 @@ function beginDeepLinkRedirect(shouldAuthenticateWithCurrentAccount = true) { // eslint-disable-next-line rulesdir/no-api-side-effects-method API.makeRequestWithSideEffects('OpenOldDotLink', {shouldRetry: false}, {}).then((response) => { if (!response) { - Log.alert('Trying to redirect via deep link, but the response is empty. User likely not authenticated.', {response, shouldAuthenticateWithCurrentAccount, currentUserAccountID}, true); + Log.alert( + 'Trying to redirect via deep link, but the response is empty. User likely not authenticated.', + {response, shouldAuthenticateWithCurrentAccount, currentUserAccountID}, + true, + ); return; }