fix: remove shouldShowError

Expensify · Dec 18, 2023 · eae6241 · eae6241
1 parent 285b87a
commit eae6241
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/src/components/ExceededCommentLength.tsx b/src/components/ExceededCommentLength.tsx
@@ -4,19 +4,10 @@ import useThemeStyles from '@hooks/useThemeStyles';
 import CONST from '@src/CONST';
 import Text from './Text';
 
-type ExceededCommentLengthProps = {
-    /** Show error when comment length is exceeded */
-    shouldShowError: boolean;
-};
-
-function ExceededCommentLength({shouldShowError}: ExceededCommentLengthProps) {
+function ExceededCommentLength() {
     const styles = useThemeStyles();
     const {numberFormat, translate} = useLocalize();
 
-    if (!shouldShowError) {
-        return null;
-    }
-
     return (
         <Text
             style={[styles.textMicro, styles.textDanger, styles.chatItemComposeSecondaryRow, styles.mlAuto, styles.pl2]}

diff --git a/src/pages/home/report/ReportActionCompose/ReportActionCompose.js b/src/pages/home/report/ReportActionCompose/ReportActionCompose.js
@@ -446,7 +446,7 @@ function ReportActionCompose({
                     >
                         {!isSmallScreenWidth && <OfflineIndicator containerStyles={[styles.chatItemComposeSecondaryRow]} />}
                         <ReportTypingIndicator reportID={reportID} />
-                        <ExceededCommentLength shouldShowError={hasExceededMaxCommentLength} />
+                        {hasExceededMaxCommentLength && <ExceededCommentLength/>}
                     </View>
                 </OfflineWithFeedback>
             </View>

diff --git a/src/pages/home/report/ReportActionItemMessageEdit.js b/src/pages/home/report/ReportActionItemMessageEdit.js
@@ -475,7 +475,7 @@ function ReportActionItemMessageEdit(props) {
                     </View>
                 </View>
             </View>
-            <ExceededCommentLength shouldShowError={hasExceededMaxCommentLength} />
+            {hasExceededMaxCommentLength && <ExceededCommentLength/>}
         </>
     );
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -475,7 +475,7 @@ function ReportActionItemMessageEdit(props) { @@
                         </View>
                     </View>
                 </View>
-                <ExceededCommentLength shouldShowError={hasExceededMaxCommentLength} />
+                {hasExceededMaxCommentLength && <ExceededCommentLength/>}
             </>
         );
     }
@@ Expand Down @@