add comments to indicate platform specific logic should be avoided at…

… all costs
Expensify · Sep 27, 2024 · ebdeca5 · ebdeca5
1 parent 94f3ef9
commit ebdeca5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/pages/ShareCodePage.tsx b/src/pages/ShareCodePage.tsx
@@ -84,6 +84,9 @@ function ShareCodePage({report, policy}: ShareCodePageProps) {
     }, [report, currentUserPersonalDetails, isReport]);
 
     const title = isReport ? ReportUtils.getReportName(report) : currentUserPersonalDetails.displayName ?? '';
+    // We should remove this logic once https://github.com/Expensify/App/issues/19834 is done
+    // We shouldn't introduce platform specific code in our codebase
+    // This is a temporary solution while Web is not supported for the QR code download feature
     const platform = getPlatform();
     const isNative = platform === CONST.PLATFORM.IOS || platform === CONST.PLATFORM.ANDROID;
     const urlWithTrailingSlash = Url.addTrailingForwardSlash(environmentURL);
@@ -139,6 +142,9 @@ function ShareCodePage({report, policy}: ShareCodePageProps) {
                         onPress={() => Clipboard.setString(url)}
                         shouldLimitWidth={false}
                     />
+                    {/* Remove this platform specific condition once https://github.com/Expensify/App/issues/19834 is done. 
+                    We shouldn't introduce platform specific code in our codebase. 
+                    This is a temporary solution while Web is not supported for the QR code download feature */}
                     {isNative && (
                         <MenuItem
                             isAnonymousAction

diff --git a/src/pages/workspace/WorkspaceProfileSharePage.tsx b/src/pages/workspace/WorkspaceProfileSharePage.tsx
@@ -122,6 +122,9 @@ function WorkspaceProfileSharePage({policy}: WithPolicyProps) {
                                 shouldLimitWidth={false}
                                 wrapperStyle={themeStyles.sectionMenuItemTopDescription}
                             />
+                            {/* Remove this once https://github.com/Expensify/App/issues/19834 is done. 
+                            We shouldn't introduce platform specific code in our codebase. 
+                            This is a temporary solution while Web is not supported for the QR code download feature */}
                             {shouldAllowDownloadQRCode && (
                                 <MenuItem
                                     isAnonymousAction