From c23db7c4d56952913f7e4e035ecd850b55240624 Mon Sep 17 00:00:00 2001 From: Aswin S Date: Fri, 5 Jan 2024 08:20:19 +0530 Subject: [PATCH 1/2] fix: tab header labels getting clipped on font scaling --- src/components/TabSelector/TabLabel.tsx | 3 ++- src/styles/index.ts | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/components/TabSelector/TabLabel.tsx b/src/components/TabSelector/TabLabel.tsx index 40f4dc30bb97..548b4ebccbc8 100644 --- a/src/components/TabSelector/TabLabel.tsx +++ b/src/components/TabSelector/TabLabel.tsx @@ -1,5 +1,6 @@ import React from 'react'; -import {Animated, StyleSheet, Text, View} from 'react-native'; +import {Animated, StyleSheet, View} from 'react-native'; +import Text from '@components/Text'; import useThemeStyles from '@hooks/useThemeStyles'; type TabLabelProps = { diff --git a/src/styles/index.ts b/src/styles/index.ts index 260f6498e8bb..a74d431f59d8 100644 --- a/src/styles/index.ts +++ b/src/styles/index.ts @@ -3709,7 +3709,8 @@ const styles = (theme: ThemeColors) => fontFamily: isSelected ? fontFamily.EXP_NEUE_BOLD : fontFamily.EXP_NEUE, fontWeight: isSelected ? fontWeightBold : '400', color: isSelected ? theme.text : theme.textSupporting, - lineHeight: 14, + lineHeight: variables.lineHeightNormal, + fontSize: variables.fontSizeNormal, } satisfies TextStyle), tabBackground: (hovered: boolean, isFocused: boolean, background: string | Animated.AnimatedInterpolation) => ({ From e261836b80eb8970d597861948af75648edf5939 Mon Sep 17 00:00:00 2001 From: Aswin S Date: Fri, 5 Jan 2024 08:57:26 +0530 Subject: [PATCH 2/2] fix: tab button height --- src/styles/variables.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/styles/variables.ts b/src/styles/variables.ts index 4d717389cdb6..83096eb5a25e 100644 --- a/src/styles/variables.ts +++ b/src/styles/variables.ts @@ -142,7 +142,7 @@ export default { signInLogoWidthLargeScreen: 144, signInLogoHeightLargeScreen: 108, signInLogoWidthPill: 132, - tabSelectorButtonHeight: 40, + tabSelectorButtonHeight: 42, tabSelectorButtonPadding: 12, lhnLogoWidth: 95.09, lhnLogoHeight: 22.33,