iOS - IOU - Preview component - Crash after tapping on the' Pay' or 'View details' buttons

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Send only one request to the user A
2. Login in iOS app as user A
3. Open the DM, tap on the "View details' or 'Pay' button

Expected Result:

The user should be able in interact with payment preview component without any issues

Actual Result:

If the user has only one payment request - the App will crash after tapping on the 'Pay' or 'View details button'
if the user has few payment request - not all comments and request will be visible after tapping on the 'Pay' or 'View details button'
This scenario also present in the Web

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.1.85-5

Reproducible in staging?: Y

Reproducible in production?: N

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5654858_Not_all_info_is_visible_if_few_money_requests.mp4

https://user-images.githubusercontent.com/43996225/179853766-bd14e670-fafd-4b23-a850-5a951b71cfba.mp4
Bug5654858_crash_-_view_details.txt

Expensify/Expensify Issue URL:

Issue reported by:
Applause internal team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[iwiznia]

@kavimuru I don't see the app crashing in your video, I assume it crashed at the last screen?

[mountiny]

cc @Julesssss seems like this could be regression from our refactoring #9878

[kavimuru]

@iwiznia I have attached crash video too.
https://user-images.githubusercontent.com/43996225/179853766-bd14e670-fafd-4b23-a850-5a951b71cfba.mp4

[mountiny]

Testing on web, I sent a request to a new account to which I havent logged in yet. When I first logged into the account I got this console error:

Havent got time now to test more, but leaving it here as potentially something to look at later.

[Julesssss]

Ugh. I spent all day on this other deploy blocker and other reviews, so didn't get around to this. If nobody has picked up it by tomorrow I'll be able to start on it

[Julesssss]

CC @chiragsalian

[mountiny]

This might be fixed with this CP, havent got around to test this.

[mountiny]

I have tested it now with the new main after the timezone fix and it seems fixed.

@kavimuru can you retest it with the latest Staging CP?

[mountiny]

Tested in the App, I can't seem to reproduce so I will close this but still ask for double checking from Applause!

[kavimuru]

@mountiny I have retested and its fixed.

LUPF1085.1.MP4

[mountiny]

Thanks!