Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - Report comment date & time always shows Today for public and phone accounts #10046

Closed
kbecciv opened this issue Jul 21, 2022 · 13 comments
Closed
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Jul 21, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing CP #10043

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in with public account (gmail) or phone account
  3. 1.Go to a report with multiple previous messages
  4. .Send a new message, verify the timestamp on that message is displayed accurately
  5. Wait a few minutes, refresh the page, verify the timestamps are still all accurate

Expected Result:

Date & Time next to usernames should be accurate

Actual Result:

Report comment date & time always shows Today for public and phone accounts

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.85.6

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): +15082211196/Feya86Katya, [email protected]/w323052760We

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5657116_Recording__886.mp4
Screen_Recording_20220721-113422_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2022

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Jul 21, 2022

Failed to reproduce, tested with a @gmail.com, @expensify.com and @expensifail.com accounts. I don't have a phone account at the moment to test.

Tested in production and staging.

@aldo-expensify aldo-expensify added the Needs Reproduction Reproducible steps needed label Jul 21, 2022
@thesahindia
Copy link
Member

@aldo-expensify, It got fixed by #10043.

@aldo-expensify
Copy link
Contributor

@thesahindia , great! thanks for letting me know :), you saved me a bunch of time .

@kavimuru
Copy link

@aldo-expensify Still able to repro with these accounts :[email protected]/Feya87Katya
+15082211196/Feya86Katya

Recording.825.mp4

image

@aldo-expensify
Copy link
Contributor

@kavimuru thanks for providing those cases, I'll test again!

@aldo-expensify
Copy link
Contributor

yep, confirmed that it still happening with that account. I looked at the messages coming in the request from the server, and the created time is fine there... so it must be something on the front

@aldo-expensify
Copy link
Contributor

There is something weird in the personal details stored for [email protected]

image

The timezone key is referencing the personal details itself

@aldo-expensify
Copy link
Contributor

This is already coming bad from the server:
image

@parasharrajat
Copy link
Member

It seems like DB needs scrutiny.

@aldo-expensify
Copy link
Contributor

Yep, it is stored in the DB like that

@aldo-expensify aldo-expensify added Reviewing Has a PR in review and removed Needs Reproduction Reproducible steps needed labels Jul 22, 2022
@aldo-expensify
Copy link
Contributor

aldo-expensify commented Jul 22, 2022

Reproduced locally and confirmed that the bug that caused this was fixed by the PR: #10043

We just have to take care of the bad timeZones that got saved into the database (will do that next)

@aldo-expensify
Copy link
Contributor

Ok, we corrected the bad timeZone value in the database, the account [email protected] (and others with the same problem) should be working fine now.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants