Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2022-08-04 #10253

Closed
OSBotify opened this issue Aug 4, 2022 · 73 comments
Closed

Deploy Checklist: New Expensify 2022-08-04 #10253

OSBotify opened this issue Aug 4, 2022 · 73 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Aug 4, 2022 •
edited by AndrewGable
Loading

Release Version: 1.1.88-15
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads
@yuwenmemon yuwenmemon added 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging and removed 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging labels Aug 4, 2022
@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 4, 2022

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.88-1 🚀

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Aug 4, 2022
@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 4, 2022

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.88-1 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 5, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.88-2 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 5, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.88-2 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 5, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.88-3 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 5, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.88-3 has been deployed to staging 🎉

@Julesssss
Copy link
Contributor

As of v1.1.88-3 this is working as expected on iOS as far as I can tell. Checking it off the deploy blocker list

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 8, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.88-4 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 8, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.88-4 has been deployed to staging 🎉

@melvin-bot melvin-bot bot added the Monthly KSv2 label Aug 8, 2022
@mvtglobally
Copy link

@roryabraham Regression is completed
PR #10070 is failing #10259. It seems reverted. Do we need to retest or ok to check it off?
PR #10197 is failing #10257. PR also was reverted. Do we retest or this is ok to checkoff now
PR #10199 Android is blocked due to #10079
PR #10226 Can you validate internally? We are unable to test debit cards due to PROD KYC wall
PR #10229 & #10276 retesting CPs now

@roryabraham
Copy link
Contributor

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 8, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.88-5 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 8, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.88-5 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 8, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.88-6 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 8, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.88-6 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 8, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.88-7 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Aug 8, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.88-7 has been deployed to staging 🎉

@mvtglobally
Copy link

#10257 is fixed.
Checking off PR #10229 & #10276 as pass
Can you also validate PR #10239 internally

@mvtglobally
Copy link

@roryabraham Lets see if we can push this deploy today
Outstanding items
#10070 - Revert PR #10299 completed. Good to check off?
#10197. issue #10257 is fixed. Should we retest main PR or it will not be relevant due to another revert?
Can you also validate PRs #10239 & #10226 internally

@mvtglobally
Copy link

@francoisl Welcome to the party. Let us know if anything needs to be re-tested to move this forward.

@francoisl
Copy link
Contributor

Thanks! Going through the list of remaining items now, I'll let you know :)

@francoisl
Copy link
Contributor

#10197. issue #10257 is fixed. Should we retest main PR or it will not be relevant due to another revert?

As far as I can tell there was no revert, so yes let's retest the main PR please

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.88-8 🚀

@mvtglobally
Copy link

@francoisl Can you share the latest APK in Slack for this retest #10199

@sketchydroide
Copy link
Contributor

Are we ok to check off the following? We are not able to validate due to PROD KYC wall - #9648, #9609, #10193

Bumped @luacmartins @ctkochan22 and @thienlnam to see if we can figure that out 😄

This was referenced Aug 23, 2022
Merged
Merged
@luacmartins
Copy link
Contributor

luacmartins commented Aug 23, 2022 •
edited
Loading

@mvtglobally for #9648, I tried adding a debit card in prod and that doesn't seem to be behind the KYCWall. Can you please confirm? If you don't have a valid credit card to be added, I think it's fine to test the fail case scenario only.

@sketchydroide
Copy link
Contributor

@mvtglobally #10310 seems like it was already internal QAed before, but it was missed on the big list, I'm waiting for @arosiclair to confirm, but I'm going to check it for now.

@sketchydroide
Copy link
Contributor

@AndrewGable tested #9648 and we can check it

@AndrewGable
Copy link
Contributor

I tested and checked off #9609

@sketchydroide
Copy link
Contributor

#10197 should be checked of, I think @luacmartins checked it off in the big list, but not on the small one. I just did though

@sketchydroide
Copy link
Contributor

#10193 - Asking @ctkochan22 how we can QA this (Although @AndrewGable might be QAing this as I write this summary)
#10144 - Asked @marcaaron what is missing
#9914 - This one is being QA by @francoisl

@ctkochan22
Copy link
Contributor

Looks like the main part of #10193 is tested. We can check off

@AndrewGable
Copy link
Contributor

Checking off #10144 since I can no longer reproduce on staging.

@sketchydroide
Copy link
Contributor

we decided to check #9914, we were not able to test it but it's under Betas and no client should be able to see it.
Slack convo here

@mvtglobally
Copy link

Lots of action today.. We are definitely looking forward for a new deploy.
Do we need to re-test anything? This checklist is huge and tracked if few places. Want to make sure I didnt miss anything

There is a potential blocker raised by contributor. Team is checking and will log if repro in a bit
https://expensify.slack.com/archives/C01GTK53T8Q/p1661266519633919

@sketchydroide
Copy link
Contributor

:shipit:

@OSBotify
Copy link
Contributor Author

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@OSBotify OSBotify reopened this Aug 23, 2022
@OSBotify OSBotify reopened this Aug 23, 2022
@OSBotify
Copy link
Contributor Author

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@OSBotify OSBotify reopened this Aug 23, 2022
@OSBotify
Copy link
Contributor Author

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@sketchydroide
Copy link
Contributor

:shipit:

@gadhiyamanan gadhiyamanan mentioned this issue Aug 25, 2022
Closed
@melvin-bot
Copy link

melvin-bot bot commented Aug 25, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

1 similar comment
@melvin-bot
Copy link

melvin-bot bot commented Aug 25, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@parasharrajat parasharrajat mentioned this issue Sep 6, 2022
Closed
@melvin-bot
Copy link

melvin-bot bot commented Sep 6, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests