Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-13] [$2000] When you long-press on a message, the message moves out of the screen frame and is hidden #10632

Open
mvtglobally opened this issue Aug 29, 2022 · 96 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering NewFeature Something to build that is a new item. Weekly KSv2

Comments

@mvtglobally
Copy link

mvtglobally commented Aug 29, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Navigate to any chat with multiple messages
  2. Long press on the last message you sent

Expected Result:

When long pressing on the last message, we should adjust the scroll so that the message you just selected is visible.

Actual Result:

When you long-press on a message in iOS mobile, the message moves out of the screen frame and is hidden.

Workaround:

None

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.1.92-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1661747398.MP4

Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661612352759039

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @JmillsExpensify
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2022

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot added the Overdue label Aug 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2022

@marcaaron Whoops! This issue is 2 days overdue. Let's get this updated quick!

@marcaaron
Copy link
Contributor

User should be able to see which messages is being selected

What does this mean exactly... ? Looking at the video and I'm not even sure what the bug is.

@melvin-bot melvin-bot bot removed the Overdue label Sep 4, 2022
@marcaaron
Copy link
Contributor

When you long-press on a message in iOS mobile, the message moves out of the screen frame, and it’s not obvious which message you’ve selected

Also don't understand what is being proposed here.

@marcaaron marcaaron added Monthly KSv2 and removed Daily KSv2 labels Sep 4, 2022
@marcaaron marcaaron assigned roryabraham and unassigned marcaaron Sep 4, 2022
@roryabraham
Copy link
Contributor

The problem is that once the context menu pops up and the modal blur is applied, it's not clear which message you've long-pressed on. What I was imagining is that the message you selected would have a white background / be "immune" from the modal blur effect.

But I think a mockup would be very helpful here. @marcaaron suggested that we could use a "shimmer effect" as an alternative

@roryabraham roryabraham added Weekly KSv2 Monthly KSv2 Design and removed Monthly KSv2 labels Sep 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2022

Triggered auto assignment to @michelle-thompson (Design), see these Stack Overflow questions for more details.

@michelle-thompson
Copy link
Contributor

Hmm, what about when you hold down on a message the background highlights as grey like so?
image

@melvin-bot melvin-bot bot added the Overdue label Sep 19, 2022
@roryabraham
Copy link
Contributor

Yeah, that works! We'll also need to make sure that we:

  • Scroll the chat view so that the highlighted chat is visible despite the context menu opening
  • Make sure we un-highlight the option when the context menu closes

@melvin-bot melvin-bot bot removed the Overdue label Sep 21, 2022
@roryabraham
Copy link
Contributor

Leaving you assigned so that you get the GH points @michelle-thompson

@melvin-bot melvin-bot bot added the Overdue label Sep 29, 2022
@roryabraham roryabraham added the External Added to denote the issue can be worked on by a contributor label Sep 30, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 30, 2022

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@JmillsExpensify
Copy link

This has since moved to this PR: #42143

@hannojg
Copy link
Contributor

hannojg commented Jun 12, 2024

After switching to the new arch we've encountered a bug in reanimated on the fabric renderer.
We are currently trying to solve it to move on with this issue:

Discussed here

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 30, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Aug 8, 2024
@perunt
Copy link
Contributor

perunt commented Aug 30, 2024

Hey @shawnborton, I left a message here to clarify this PR. I look forward to your answer

@luacmartins
Copy link
Contributor

Assigning myself to cover for Rory while he's on parental leave

@luacmartins luacmartins self-assigned this Oct 10, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Jan 1, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@luacmartins
Copy link
Contributor

Damn, it's a shame that we reverted the PR 😞 @kirillzyusko let's work on v2 taking the blockers into consideration

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 6, 2025
@melvin-bot melvin-bot bot changed the title [$2000] When you long-press on a message, the message moves out of the screen frame and is hidden [HOLD for payment 2025-01-13] [$2000] When you long-press on a message, the message moves out of the screen frame and is hidden Jan 6, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 6, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 6, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-13. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 6, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests