Web - VBA - Wrong URL when connect to bank account manually page is closed @aneequeahmad

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com or new.expensify.com
2. Log in with any account
3. Click on use icon to open setting page.
4. Click on workspace > issue cards > connect bank account
5. Click on back arrow on connect account page.
6. Click on connect bank account > connect manually.
7. Click the X to close the modal
8. Observe the web URL is incorrect (i.e the workspace URL)

Expected Result:

Should show the url r/reportId

Actual Result:

Url is changed to workspace/workspaceId

Workaround:

Uknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.99.4

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

workspace-url-bug.mov

Expensify/Expensify Issue URL:

Issue reported by: @aneequeahmad

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661443887135869

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

Triggered auto assignment to @trjExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[trjExpensify]

👋 Zany, I think this was supposed to go to Engineering yeah? Adding the label.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

I can't seem to reproduce this in either staging or prod:

Screen.Recording.2022-09-13.at.12.49.54.PM.mov

[aneequeahmad]

@jasperhuangg Issue is reproducible in production

Action performed:

• Go to staging.new.expensify.com
• Log in with any account
• Click on use icon to open setting page.
• Click on workspace > issue cards > connect bank account.
• Click on back arrow on connect account page.
• Click on connect bank account > connect manually.
• Click on cross icon on connect manually page.

Video:

bug-url-bank-account.mov

[trjExpensify]

Yeah, this isn't consistent, but it's reproducible. It's something to do with if you close the modal after being on a settings page first, as opposed to coming from a chat report I think.

1. Go to staging.new.expensify.com
2. Log in with any account
3. Click into a chat report in your LHN
4. Click on use icon to open setting page.
5. Click on workspace > connect bank account.
6. Click on connect manually
7. Click the X to close the modal
8. Observe the web URL is correct (i.e the chat report)

Versus

1. Go to staging.new.expensify.com
2. Log in with any account
3. Click on use icon to open setting page.
4. Click on workspace > issue cards > connect bank account
5. Click on back arrow on connect account page.
6. Click on connect bank account > connect manually.
7. Click the X to close the modal
8. Observe the web URL is incorrect (i.e the workspace URL)

That's how I was able to reproduce it. Reopening.

[jasperhuangg]

Got it, so it wasn't that I opened it from a chat report, it was actually that I missed the step to click "back" first before entering the connect account page again and clicking close. Updating the OP to reflect this.

I'm also finding that it happens on both staging AND production.

This is definitely a good candidate for an external contributor, gonna mark as External

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jasperhuangg]

Ahh I think my wifi connection was spotty so the External label didn't get applied when I clicked it ooops

[parasharrajat]

Note: #10939 (comment) I think it should be considered duplicate or all of these issues should be tracked simultaneously.

IMO, these are the same issues. The real issue is with the nested level of RHN modals. This GH is just talking about different pages.

So basically if there is a navigation issue, it can affect multiple pages. it does mean we should track all of those pages separately. As one solution will do the trick for all.

Moreover, this should be held as other navigation issues. We are planning to look into the navigation configuration for the app which can affect a lot of things. All other navigation issues are on hold.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[jasperhuangg]

I can create one! I've been able to find the following issues (in addition to this one) that are related to the same navigation issue @parasharrajat was describing:

#10939
#10989
#10991

Any others? I'm going to create a parent tracking issue and link all of these issues, and HOLD that parent tracking issue on navigation.

[jasperhuangg]

#11111 @parasharrajat

[parasharrajat]

Thanks, @jasperhuangg. It is a great help. Please add that to the Navigation project as well. I can see a few more. I will comment there for others.

[michaelhaxhiu]

Baller, thanks @jasperhuangg!

[michaelhaxhiu]

Should we close this one now?

[jasperhuangg]

@michaelhaxhiu sounds good!

[aneequeahmad]

@jasperhuangg This has also been fixed and the reporting compensation is pending.

[aneequeahmad]

Also another broken URL issue #10887

These are the only 2 issues left for reporting bonus payment.

cc: @jasperhuangg

[jasperhuangg]

@aneequeahmad I reached out to @sonialiap to get that sorted for you, thanks for making me aware.

[jasperhuangg]

@jasperhuangg This has also been fixed and the reporting compensation is pending.

@michaelhaxhiu was this issue created before we removed reporting bonuses?

[jasperhuangg]

Feel free to close out the issue if payment was issued/no next steps need to be taken.

[aneequeahmad]

@jasperhuangg I can see that @michaelhaxhiu account is deactivated in Slack #expensify open source. I think you can assign this to someone else for issuing payment. Thanks

[melvin-bot]

@michaelhaxhiu, @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[jasperhuangg]

@adelekennedy Let's pay out $250 to @aneequeahmad as the reporting bonus for this issue (it was created when reporting bonuses still existed).

[adelekennedy]

@aneequeahmad sent offer on Upwork!

[aneequeahmad]

@adelekennedy accepted offer. Thanks

[adelekennedy]

Payment made! @jasperhuangg anything else that needs to be done for this issue or can we close it out?

[jasperhuangg]

I think we're good here, thanks for sorting that out!