Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #11768] Wrong URL when new chat is selected from new chat list - Reported by @aneequeahmad #11092

Closed
mvtglobally opened this issue Sep 19, 2022 · 39 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open web app and see the opened chat and its URL.
  2. Click on + icon in LHN > new chat.
  3. Select any chat in the New Chat list.
  4. See the URL and opened chat.
  5. Refresh the page.

Expected Result:

Chat URL should be of new chat opened.

Actual Result:

Chat URL is of old chat and not of new chat opened.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-08-30.at.12.20.25.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @aneequeahmad
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661801189415899

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Sep 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Sep 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Sep 19, 2022

Oh interesting! Sending to eng for a second opinion on getting this job in Upwork - seems worth it to me!

@Christinadobrzyn Christinadobrzyn removed their assignment Sep 19, 2022
@pecanoro
Copy link
Contributor

I reproduced this, the problem here is that when you create a new chat, the URL does not get updated and the one with the previous chat stays.

@pecanoro pecanoro removed their assignment Sep 19, 2022
@pecanoro pecanoro added Improvement Item broken or needs improvement. External Added to denote the issue can be worked on by a contributor labels Sep 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

Triggered auto assignment to @arielgreen (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@arielgreen
Copy link
Contributor

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 21, 2022
@arielgreen arielgreen added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Sep 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2022

Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2022

Triggered auto assignment to @NikkiWines (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@JmillsExpensify
Copy link

Still on hold for navigation. No ETA.

@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2023
@JmillsExpensify
Copy link

Same same

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 17, 2023
@JmillsExpensify
Copy link

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Mar 29, 2023
@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@JmillsExpensify
Copy link

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label May 3, 2023
@JmillsExpensify JmillsExpensify removed the Improvement Item broken or needs improvement. label May 5, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2023
@JmillsExpensify
Copy link

Coming off hold very soon!

@melvin-bot melvin-bot bot removed the Overdue label Jun 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 10, 2023
@JmillsExpensify
Copy link

Working on testing this week.

@melvin-bot melvin-bot bot removed the Overdue label Jul 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2023
@JmillsExpensify
Copy link

Still trying to make time. Low priority.

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2023
@JmillsExpensify
Copy link

@aneequeahmad Same here. Please retest your reproduction steps above and confirm that you receive the expected result. At that point we can confirm that it's fixed and pay you for reporting.

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@JmillsExpensify
Copy link

Same as above.

@aneequeahmad
Copy link
Contributor

@JmillsExpensify Tested the reproduction steps. Results are as expected. Video is attached for verification

Fix-NewChat-Refresh-pg.mp4

@aneequeahmad
Copy link
Contributor

@JmillsExpensify please verify the video attached above and lets close this issue. Thanks

@JmillsExpensify
Copy link

Thanks for closing the loop. I've sent the offer, please prioritize accepting it so we can get this closed out.

@aneequeahmad
Copy link
Contributor

@JmillsExpensify accepted the offer. Thanks

@JmillsExpensify
Copy link

Thanks, all paid out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2
Projects
None yet
Development

No branches or pull requests