Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-09-26 #11297

Closed
19 tasks done
OSBotify opened this issue Sep 26, 2022 · 15 comments
Closed
19 tasks done

Deploy Checklist: New Expensify 2022-09-26 #11297

OSBotify opened this issue Sep 26, 2022 · 15 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Sep 26, 2022

Release Version: 1.2.7-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 26, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.7-1 🚀

@roryabraham
Copy link
Contributor

#10899 passed internalQA, checking it off

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.7-2 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.7-2 has been deployed to staging 🎉

@mvtglobally
Copy link

mvtglobally commented Sep 27, 2022

@roryabraham
Regression is completed
PR #10811 is failing due to #11205. Happening is PROD too.
PR #11165 is failing due to #11186
PR #11211 is failing due to #11330 & #11332 & #11333

@luacmartins
Copy link
Contributor

Checking off #11165. While it did not fix the issue (and the test steps fail), it's still a clean up for this PR.

@roryabraham
Copy link
Contributor

Checking off #11211. The reported bug is pretty minor, and may or may not be the expected behavior. Left some additional thoughts here. Not going to treat as a blocker.

@roryabraham
Copy link
Contributor

@mvtglobally #11301 should be fixed by #11303 in 1.2.7-2, can you please retest?

@roryabraham
Copy link
Contributor

#11305 is fixed, checking it off

@mvtglobally
Copy link

#11303 is PASS. Let me double check the #11301

@roryabraham
Copy link
Contributor

I was able to verify that #11301 is fixed, checking it off

@roryabraham
Copy link
Contributor

Going to work on QA of #11254

@roryabraham
Copy link
Contributor

The crash seems like a memory leak problem in React Native itself. Going to ignore for now because I don't think there's much we can do about it, but we'll monitor it and hopefully see an issue created if it persists.

@roryabraham
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants