Web - Closing App download links page in settings page is causing incorrect URL settings/about instead of r/reportId - reported by @aneequeahmad

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login in web app.
2. Open settings page > profile > click add phone number
3. Click on back arrow on this page to navigate to profile page.
4. Click on back arrow to navigate to settings page.
5. Click on about > app download links.
6. Click on cross (x) to close app download links page.

Expected Result:

URL should be r/reportId.

Actual Result:

URL is settings/about

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.2.5-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bug-url-about-page.mov

Expensify/Expensify Issue URL:
Issue reported by: @aneequeahmad
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1662818840728789

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mallenexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[aneequeahmad]

@mallenexpensify, I think this should be added to #11111 as per @parasharrajat comment. Thanks

[mallenexpensify]

Thanks @aneequeahmad . @jasperhuangg , since you created lucky issue #11111 , do you agree? if so... wanna add to that then update this issue, inc. adding [HOLD #11111] to the beginning of the title?

[melvin-bot]

@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

@jasperhuangg , do you think this should be added to #11111?

[jasperhuangg]

@mallenexpensify good call, this is exactly the same issue as described in #11111

[mallenexpensify]

Thanks @jasperhuangg , I updated the OP for #11111 @jasperhuangg should I put this on hold dependent on #11111 ?

[melvin-bot]

@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

Unable to reproduce and seems like a low-value edge case. Closing, comment if anyone disagrees

[JmillsExpensify]

Re-opening this issue now that we're done with the react navigation refactor.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[JmillsExpensify]

Here's my summary:

• We've deprecated the close button, so that's not longer a relevant part of the testing steps
• Further, when I following the remaining testing steps, the URL is correct in each case.

Accordingly, I think we're good to go here and we'll pay out @aneequeahmad $250 for reporting.

[mallenexpensify]

@aneequeahmad, can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~0194114032474252c5

[melvin-bot]

@JmillsExpensify, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[aneequeahmad]

@mallenexpensify I accepted the offer thankyou

[JmillsExpensify]

Sent the offer via the link Matt provided above.

[melvin-bot]

@JmillsExpensify, @mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

[mallenexpensify]

@aneequeahmad paid! Closing