Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimbursable - After reload on changing unit when you click outside the it goes back to the previous value reported by @puneet-here #11698

Closed
kbecciv opened this issue Oct 10, 2022 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 10, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Go to settings > Workspace > Reimburse expenses
  3. Reload the page and change unit > now click outside to remove the focus

Expected Result:

The value shouldn't change

Actual Result:

The value changes

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.12.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/194879414-b16eb638-7eaa-4e8a-9b6d-c2fa7a799d25.mp4
https://user-images.githubusercontent.com/93399543/194879416-d36ffbce-3cbe-4f20-846c-dcc806006da5.mp4

Screen.Recording.2022-10-09.at.2.35.29.AM.1.mov

Expensify/Expensify Issue URL:

Issue reported by: @Puneet-here and Applause internal team

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665263408333949

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2022

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kavimuru kavimuru changed the title Reimbursable - After reload on changing unit when you click outside the it goes back to the previous value Reimbursable - After reload on changing unit when you click outside the it goes back to the previous value reported by @puneet-here Oct 10, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 12, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 14, 2022

@danieldoglas Whoops! This issue is 2 days overdue. Let's get this updated quick!

@danieldoglas
Copy link
Contributor

This might be related to this PR

@melvin-bot melvin-bot bot removed the Overdue label Oct 17, 2022
@danieldoglas
Copy link
Contributor

@kbecciv actually I was not able to simulate this again. Can you please try it again?

@kbecciv
Copy link
Author

kbecciv commented Oct 17, 2022

@danieldoglas Checking, updating you shortly

@kbecciv
Copy link
Author

kbecciv commented Oct 17, 2022

Unable to reproduce it with build 1.2.16.4

Recording.1459.mp4

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 19, 2022
@danieldoglas
Copy link
Contributor

Moving this to weekly but looks like we can't reproduce it anymore.

@melvin-bot melvin-bot bot removed the Overdue label Oct 20, 2022
@danieldoglas danieldoglas added Weekly KSv2 and removed Daily KSv2 labels Oct 20, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2022
@danieldoglas
Copy link
Contributor

@kbecciv is this still not reproducible?

@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2022
@kbecciv
Copy link
Author

kbecciv commented Oct 31, 2022

@danieldoglas Checking, update you shortly.

@kbecciv
Copy link
Author

kbecciv commented Oct 31, 2022

Unable to reproduce it with build 1.2.21.4

Recording.1557.mp4

@danieldoglas
Copy link
Contributor

Ok, closing this issues since it was not reproducible for 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants