Better default empty states with animation #12261
Comments
|
Auto-assign attempt failed, all eligible assignees are OOO. |
|
Adding a note that as part of this conversation here, we've decided to remove this one from the WAQ Project. That doesn't mean we shouldn't do this, but let's prioritize all other WAQ issues first before moving onto this one. |
|
I personally haven't invested any time into this yet, but I'm definitely excited to work on it when the time is right. @shawnborton keep me posted on next steps and let me know how I can help! We'll also want keep an eye on this absolutely monstrous PR to add new architecture support in Lottie |
|
Ha @shawnborton what a coincidence. Check out the reviewer on that linked PR! |
|
Hah, what are the odds! In other news, I'll post some ideas to the room today and we'll get kicked off with Augenblick next week. |
|
Augenblick sent over some test animation Lottie files for us - they are mostly looking for freedback on if this format will work, and how the file size is. Thoughts @roryabraham ? Files: Expensify_LottieTests_112222.zip Given that the JSON file size is less than 100KB, I think this is going to work great.
|
|
I'll see if I can get a POC together ... @shawnborton is there any existing screen that I can work on putting one of these in already? That way we could actually merge it and the POC won't end up getting really out-of-date |
|
I don't think we have an existing screen to use for this yet, we'd be making new layouts as part of this project. |
|
Shouldn't this issue be on hold for WAQ? |
|
We discussed this previously and agreed that it makes sense to get started with Augenblick on this because we can do that in parallel to WAQ without needing Engineering resources. That being said, I can see an argument for Rory to hold off on doing any kind of engineering testing here given that he should be prioritizing WAQ. I still think it makes sense for us to be doing this work with Augenblick in the meantime though. |
|
Haven't invested any time in this yet, but I'm excited to do so when the time comes! |
|
Ok cool, yeah totally agree we can push forward with Augenblick, I just don't think we should push forward with any engineering time until we're in a better spot with WAQ. I'm throwing a HOLD on this issue to make sure that's clear, though please feel free to use the issue for on-going Augenblick updates. |
JmillsExpensify
changed the title
|
Still on HOLD (for my part, anyways...) |
|
Not overdue. We have all of our animations and Lottie files completed, we just need to wait for WAQ to be finished and then we can hopefully start working through this one. Some treats for you:
|
|
We're getting real close on the bugs. The bigger blockers for WAQ are going to be the headline initiatives, so once we get those out of the way we'll be back at it! |
|
Not overdue, still holding. |
|
I reviewed #21852. Bumping for the payment! |
|
@shawnborton, @roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick! |
|
@shawnborton, @roryabraham 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
|
@roryabraham what is the latest here? Can we please try to wrap this up as soon as possible? It feels like we're so close but this one keeps dragging on. Does it make sense to give this one to some contributors or even an agency? |
|
@shawnborton, @roryabraham Huh... This is 4 days overdue. Who can take care of this? |
|
@shawnborton, @roryabraham Still overdue 6 days?! Let's take care of this! |
|
@roryabraham can you please provide an update here? |
|
Creating some external issues to build out these animations: |
|
Created a separate issue to track enabling lottie file format: #26857 |
|
We're working in parallel on the security and about pages, as well as DotLottie file formats. @shawnborton Also created #27211 |
|
Created #27407 – the final page for this issue |
|
Just fixed the animation for the About page |
|
So the last piece here is the about page, and for some reason the animation just doesn't work normally on iOS Safari. We can hack a fix by using a canvas renderer instead of svg, but that messes up the heights. We should be able to hack a fix for the height, but I wonder if we might just ask Augenblick if they can see if there's something wrong with the animation in AfterEffects |
|
Maybe we hack a fix then create a follow-up |
|
@shawnborton, @roryabraham Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
|
Because the last holdout here is the About page, and the About page is being handled in #26779, I think we can close this out! We're also implementing more improvements to our usage of lottie, but they're also being handled separately |
|
Amazing!!
…On Mon, Sep 25, 2023 at 11:21 PM Rory Abraham ***@***.***> wrote:
Closed #12261 <#12261> as
completed.
—
Reply to this email directly, view it on GitHub
<#12261 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARWH5SYOFMP2RQUZWQ4FPLX4GORFANCNFSM6AAAAAARRJK5N4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Note: This issue is part of the greater Implement Our New Branding in NewDot project.
What is it:
Bring life to our app by animating various empty states illustrations. We can split this project into two phases: first, let’s identify areas where we can use illustrations for empty states. Augenblick can help us create new illustrations. Then we can take those illustrations and bring them to life with animation. Again, Augenblick can help us by animating these illustrations. We can then use Lottie to implement the animations into the product.
Does it require a mini design doc:
Yes
Design finished:
No
cc @GabiHExpensify
The text was updated successfully, but these errors were encountered: