Deploy Checklist: New Expensify 2022-11-30

[OSBotify]

Release Version: 1.2.34-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Remove Report_IOUs key from Onyx #12780
• Core Branding Add New Icons #12796
• support copy & paste emojis into composer #12937
• [NO QA] Allow notification debugging for release builds on Android #12964
• Navigate to workspace settings after workspace deletion #12971
• Fix console error on focus #12992
• [No QA] Add comment for targetOffset calculation #13007
• IOUModal animation between steps fix #13018
• [No QA] remove .env.temp #13052
• Refactor companystep to use Form -2 #13076
• fix android keyboard issue #13106
• Fix incorrect pasted text on copied HTML snippet #13108
• Dark Mode: Make Menu Icons Green #13109
• Fix autofill styles #13119
• Fixed: Text select cursor is not appearing when selecting text in the messages #13120
• [No QA] Link to workflow run using upstream feature #13121
• [No QA] Use upstream softprops/turnstyle #13122
• Dark Picker Icon Colour Scheme Added #13142
• Fix autofill colors #13164
• Add reimbursement account draft #13167
• Add a color to the options in the picker when using Windows #13174
• Revert filtering out workspaces with pending delete action #13201

Internal QA:

• Update version of expensify-common #13012 - @cead22 @srikarparsi

Deploy Blockers:

• Web - Login - The empty welcome page + error in console after login #13025
• [HOLD for payment 2022-12-08] Android -Chat - The compose field is covered by keyboard #13111
• [HOLD for payment 2022-12-08] Profile - If user uses saved information, background turns white & is very hard to read #13116
• [HOLD for payment 2022-12-20] [HOLD for payment 2022-12-08] Profile - The tabs for "Preferred pronouns" or "Set my time zone automatically" are showing white spaces #13127
• [$1000] Icons in VBA flow are very hard to see or white in dark mode #13132
• [HOLD for payment 2022-12-08] Workspace - Delete workspace error icon & message do not appear for failed scenario #13192
• Web - Login - The error in the console after login in HT account #13205

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.34-0 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.34-1 🚀

[mvtglobally]

@luacmartins we are still working on the checklist. Here is a mid-summary

#12796 (comment)
#13109 (comment)
#12971 (comment)
#13167 (comment)

[luacmartins]

@mvtglobally

• Core Branding Add New Icons #12796 (comment) and Dark Mode: Make Menu Icons Green #13109 (comment) I'd say to make sure that the colors/icons match the screenshots shared on those PRs

• Navigate to workspace settings after workspace deletion #12971 (comment) I couldn't reproduce that issue on staging or locally.

• Add reimbursement account draft #13167 (comment) yes, we should test this

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.34-1 has been deployed to staging 🎉

[luacmartins]

@mvtglobally what's the status on the regression tests?

[mvtglobally]

@luacmartins app is really slow and lagging. We are about 60% but regression takes longer now due to slowness as well.

[luacmartins]

@mvtglobally could you give me another update on the regression tests please?

[mvtglobally]

@luacmartins around 25% left.

[mvtglobally]

@luacmartins we are at 11%.
Can you internally help out with pR #12796. Team is not very sure on validations here. It will help a lot

[luacmartins]

@mvtglobally thanks for the update! I'll check that PR.

[luacmartins]

#12796 is a pass! Checking it off!

[mvtglobally]

PR #13109 is failing with #13222. repro in PROD
PR #13201 is failing #13192.

[mvtglobally]

@luacmartins Regression is completed

[luacmartins]

• Dark Mode: Make Menu Icons Green #13109 is a pass. I just commented on Workspace -View all bills icon does not match the provided screenshots under Pay bills and Send invocies #13222
• Revert filtering out workspaces with pending delete action #13201 is a pass!

web.mov

[luacmartins]

Checklist is clear and there are no new crashes. Kicking off the deploy!

[luacmartins]