Message is not marked as read in LHN when opening same message again

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open any message
2. Right click to 'Mark Unread' the message
3. Return the chat list view (message should be bolded as if it is unread)
4. Open the same chat again
5. Return the chat list view, see that chat is still bolded despite it having been read

Expected Result:

Report should not be bolded in the LHN after re-opening the chat

Actual Result:

Report is bolded in the chat list despite having been re-opened/read

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• iOS / native

Version Number: 1.2.42-0
**Reproducible in staging?:**y
**Reproducible in production?:**y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

ScreenRecording.2.mov

QFFW4679.MP4

Expensify/Expensify Issue URL:
Issue reported by: @abdulrahuman5196
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671290524425899

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017db106fd914a1192
• Upwork Job ID: 1606044643909046272
• Last Price Increase: 2022-12-22

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[stephanieelliott]

Hey @kavimuru when you say "report" I think you meant Request Money right?

If so, I was able to repro this on iOS

[kavimuru]

@stephanieelliott Sorry, I have updated the title. I copy pasted bug from the slack as it is.

[stephanieelliott]

Cool, thanks @kavimuru! That makes sense now, updated the action steps based on that.

I think this can be worked on externally.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017db106fd914a1192

[melvin-bot]

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Triggered auto assignment to @amyevans (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mountiny]

This is related to unread messages and sequence numbers, I am putting this on hold for once the refactor is finished, added it to the tracking list https://github.com/Expensify/Expensify/issues/227234

[Prince-Mendiratta]

Since I had already begun to test this before this was marked as out of scope, to add onto my findings to this issue anyways -

This bug can be found on all browsers as long as they have a separate LHN window.
The bold mark doesn't go away unless either the page is refreshed and the chat is opened and then closed or another chat is opened first before opening the marked chat.

Even when the message is marked as read after opening the chat after a refresh, the --New indicator still persists on opening the app again until another chat is opened.

2022-12-23.04-12-05.mp4

[onesh]

Hi team, how are we managing the state for storing the chats ?

With the information on this page I can surely say that the state does gets updated once the chat is marked as unread (that’s why when we go back, the last message is boldened) but when that chat is opened again, there should be another callback that unchecks a flag in that chat object in the state and triggers a re-render. Perhaps the best way to do that could be using useEffect if we are using hooks because that lets you mutate the state object before the component is rendered so as to prevent subsequent renders.

Could you please point me to the code/files for this bug to have a closer look?

Thanks!

[melvin-bot]

@amyevans, @parasharrajat, @stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JmillsExpensify]

That being said, I will go ahead and send the Upwork offer. Thanks!

[melvin-bot]

@JmillsExpensify, @amyevans Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@JmillsExpensify, @amyevans Whoops! This issue is 2 days overdue. Let's get this updated quick!

[abdulrahuman5196]

@JmillsExpensify I tested again and the issue is reproducible. It could be my bad that it was not reproducible the last time i tested.

Screen.Recording.2023-11-13.at.8.35.09.PM.mov

[melvin-bot]

@JmillsExpensify, @amyevans Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JmillsExpensify]

Ok all good! So what next steps do ya'll recommend? Open this back up for proposals?

[abdulrahuman5196]

I think yes.

[melvin-bot]

@JmillsExpensify, @amyevans Huh... This is 4 days overdue. Who can take care of this?

[parasharrajat]

Please assign me back to the issue and I will start reviewing it.

[situchan]

cc: @MonilBhavsar to put this on your radar

[amyevans]

Posted this in Slack as well, but I cannot repro.

test-13740.mov

[MonilBhavsar]

This should be fixed! We can retest and most probably close this

[melvin-bot]

@JmillsExpensify, @amyevans 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[JmillsExpensify]

@lanitochka17 Mind trying to reproduce this one? At that point we can close.

[JmillsExpensify]

Though actually, I think @amyevans confirmation is enough. Going to issue payment for reporting to @abdulrahuman5196.

[abdulrahuman5196]

Accepted the new offer @JmillsExpensify

[JmillsExpensify]

All paid out. Thank you!

[JmillsExpensify]

P.S. I discovered a duplicate offer, so I've just closed that one out. Sorry for the confusion.