[HOLD for payment 2024-08-05] [$1000] Standardize on single fontFamily names across platforms

[luacmartins]

Problem

Coming from this discussion, react-native-asset let's us easily link and manage assets, including fonts. However, it fails to provide a cross platform way to use font typeface modifiers such as fontWeight and fontStyle in combination with a custom fontFamily name, in both iOS and Android, which in turn results in keeping multiple font-families such as, ExpensifyNewKansas-Medium, ExpensifyNewKansas-MediumItalic instead of a single ExpensifyNewKansas font-family.

iOS seems to work out of the box as long as we use the postScript name for the font. However, android uses the font filename which results in the different fontFamilies above.

Why is this important

Ease of importing new fonts and keeping/maintinaing a single font type-face.

Solution

Update react-native-asset to support XML fonts in android and auto-group font families into XML fontFamilies.

cc @roryabraham

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0165fabbe62a87ed20
• Upwork Job ID: 1641731454588358656
• Last Price Increase: 2023-03-31

Issue Owner

Current Issue Owner: @sakluger / @zanyrenney

[roryabraham]

cc @Luke9389 for visibility

[grgia]

nice!

[Luke9389]

Love it! Thanks y'all

[roryabraham]

No update yet

[roryabraham]

Sorry for the delay here. I'm going to make this a weekly, but my plan here is to:

1. Create a couple simple demo React Native projects to show the difference between the "old" way of bundling fonts that we use today vs the "new" way (i.e: Android xml fonts)
2. Then create an issue in https://github.com/unimonkiez/react-native-asset to show the "before" and "after" that explains what we would expect react-native-asset to do, given font assets in the top-level assets directory.
3. Once that is done, we can re-group, but it's likely I would want to pass this off to an expert contractor (or even better, hire the react-native-asset maintainer directly) to do the actual implementation. I think I could implement it, but I just don't know when I'll have enough time.

[Luke9389]

I think that sounds great @roryabraham. Thanks for the update

[roryabraham]

No update this week :(

[roryabraham]

No update again

[sakluger]

@zanyrenney assigning you to help watch this issue while I'm OOO through May 31. Please handle payment if needed. I'll take back over if it's still open when I return.

[zanyrenney]

sounds good @sakluger

[fabioh8010]

Update: There is still some feedback I need to address in the PR before removing the WIP label. I plan to address everything next week as this one I need to focus to get the detailed section of a design doc ready to review.

[fabioh8010]

Update: Applied the last feedbacks and removed the PR from WIP state, review and testing can resume.

[roryabraham]

Looks like a number of bugs were reported in the AdHoc testing

[fabioh8010]

Reviewed all bugs reported and fixed one bug related to this PR, it's ready to review again.

[melvin-bot]

This issue has not been updated in over 15 days. @sakluger, @fabioh8010, @luacmartins, @mollfpr, @roryabraham, @zanyrenney eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[fabioh8010]

Still under review Melvin

[roryabraham]

PR finally merged

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.13-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use Font XML resources and standardise font usage on native platforms #41115

If no regressions arise, payment will be issued on 2024-08-05. 🎊

For reference, here are some details about the assignees on this issue:

• @fabioh8010 does not require payment (Contractor)
• @mollfpr requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@sakluger / @zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @fabioh8010 is from an agency-contributor and not due payment
• Reviewer: @mollfpr owed $250 via NewDot

BugZero Checklist (@sakluger)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1641731454588358656/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[sakluger]

I'm pretty sure we don't need any new regression tests here. @mollfpr please request payment via NewDot using the payment summary above. Thanks!

[mollfpr]

Thanks @sakluger! Could you confirm if the first amount of bounty applied here?

[JmillsExpensify]

$250 approved for @mollfpr