Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$4000] Multiple weird issues on combination of expand message and scroll in chat message list page #14291

Closed
2 tasks
kavimuru opened this issue Jan 13, 2023 · 28 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@kavimuru
Copy link

kavimuru commented Jan 13, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to any chat
  2. Type some text and expand the message and open keyboard
  3. Scroll the view
  4. Type combinations of above 2

Expected Result:

Scrolling and expand should work properly

Actual Result:

  1. There is blank background space below the compose box that shouldn't be there
  2. The size of the compose box grows when scrolling though it shouldn't

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / Chrome
  • iOS / Safari

Version Number: 1.2.54-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

MXZE8121.2.MP4
ScreenRecording.4.mov

Expensify/Expensify Issue URL:
Issue reported by: @abdulrahuman5196
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673596288476119

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f84b7526ce4ad48b
  • Upwork Job ID: 1615450817743364096
  • Last Price Increase: 2023-01-31
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 13, 2023

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 13, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 16, 2023
@puneetlath
Copy link
Contributor

@kavimuru you mention "multiple weird issues on view positions and scrolling". Can you list what those issues are? From trying myself I see:

  1. There is blank background space below the compose box
  2. The size of the compose box grows when scrolling

Is there anything else?

@melvin-bot melvin-bot bot removed the Overdue label Jan 16, 2023
@kavimuru
Copy link
Author

@puneetlath scrolling issue and header also disappears when scrolling up, compose box is resizing when scrolling.

PKEQ2482.1.MP4

@puneetlath puneetlath added the External Added to denote the issue can be worked on by a contributor label Jan 17, 2023
@melvin-bot melvin-bot bot unlocked this conversation Jan 17, 2023
@melvin-bot melvin-bot bot changed the title Multiple weird issues on combination of expand message and scroll in chat message list page [$1000] Multiple weird issues on combination of expand message and scroll in chat message list page Jan 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 17, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01f84b7526ce4ad48b

@melvin-bot
Copy link

melvin-bot bot commented Jan 17, 2023

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Jan 17, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 17, 2023

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

@eh2077
Copy link
Contributor

eh2077 commented Jan 18, 2023

It looks like duplicated, see #14161 (comment)

@melvin-bot melvin-bot bot added the Overdue label Jan 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 20, 2023

@puneetlath, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@s77rt
Copy link
Contributor

s77rt commented Jan 21, 2023

There is blank background space below the compose box that shouldn't be there

I think I saw an issue that reported that already and we decided to do nothing.

Header doesn't stay fixed when scrolling

This is already being handled here #13491
There is a possibility that this will be fixed after applying #13801 and #14392 However I don't think it will completely stay fixed as we are constantly applying marginTop style to the <ReportScreen /> (more details on the linked issue and PR)

@puneetlath
Copy link
Contributor

It looks like duplicated, see #14161 (comment)

@eh2077 this seems similar to that issue, but not exactly the same.

I think I saw an issue that reported that already and we decided to do nothing.

Can you like to that @s77rt? It's not clear to me why we would choose to do nothing for this.

This is already being handled here #13491

Cool, thanks! I'll remove that from the scope of this issue.

@melvin-bot melvin-bot bot removed the Overdue label Jan 23, 2023
@s77rt
Copy link
Contributor

s77rt commented Jan 23, 2023

@puneetlath Sorry I don't remember what issue it was, maybe it was a different issue after all. FWIW there are many issues that are related to empty blank space that worth checking such as this one #13219 (although it's reported for mWeb not native, it's pretty similar)

@melvin-bot melvin-bot bot changed the title [$1000] Multiple weird issues on combination of expand message and scroll in chat message list page [$2000] Multiple weird issues on combination of expand message and scroll in chat message list page Jan 24, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 30, 2023
@melvin-bot melvin-bot bot changed the title [$2000] Multiple weird issues on combination of expand message and scroll in chat message list page [$4000] Multiple weird issues on combination of expand message and scroll in chat message list page Jan 31, 2023
@sobitneupane
Copy link
Contributor

sobitneupane commented Feb 1, 2023

The size of the compose box grows when scrolling though it shouldn't

I was unable to reproduce this issue on IOS/Safari.

@melvin-bot melvin-bot bot removed the Overdue label Feb 1, 2023
@puneetlath
Copy link
Contributor

I just tried and I'm still able to reproduce this on iOS safari @sobitneupane.

@ArekChr
Copy link
Contributor

ArekChr commented Feb 6, 2023

I would like to investigate this issue, Callstack.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Feb 6, 2023

📣 @ArekChr You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@ArekChr
Copy link
Contributor

ArekChr commented Feb 7, 2023

Hello,

About my update, I noticed this issue combines the other problems on mWeb with over-scroll behaviour.
I found a lot of similar issues related to unwanted padding between the keyboard and input that occur in many projects. This issue is likely associated with WebKit, related thread here: https://bugs.webkit.org/show_bug.cgi?id=141832 Unfortunately, I haven't been able to turn off the scroll completely from the CSS level.

The issue is very tricky. From the dev tools inspector, I noticed that spacing between the keyboard and input is not accessible when focusing on the entire HTML element, the screenshot above.

Zrzut ekranu 2023-02-7 o 14 09 09

@melvin-bot melvin-bot bot added the Overdue label Feb 9, 2023
@MelvinBot
Copy link

@puneetlath @ArekChr @sobitneupane this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

  • Decide whether any proposals currently meet our guidelines and can be approved as-is today
  • If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Feb 10, 2023
@MelvinBot
Copy link

Current assignee @sobitneupane is eligible for the Internal assigner, not assigning anyone new.

@MelvinBot
Copy link

@puneetlath, @ArekChr, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@puneetlath
Copy link
Contributor

I chatted with callstack in slack and they're going to see if they can pull in some other devs on this.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Feb 10, 2023
@puneetlath
Copy link
Contributor

Callstack is hoping to have a sr dev look into this tomorrow.

@melvin-bot melvin-bot bot removed the Overdue label Feb 13, 2023
@tjaniczek
Copy link

Hi @puneetlath , I'm looking into this since yesterday. So far with no success, unfortunately. I'll try out a couple of other ideas today as well. But with this being known iOS issue, chances of fixing this behaviour to full extend are bleak. Will keep you posted

@mountiny mountiny assigned tjaniczek and unassigned ArekChr Feb 15, 2023
@tjaniczek
Copy link

tjaniczek commented Feb 16, 2023

Hi @puneetlath , as the last effort I tried to find a workaround by applying absolute/fixed positioning to the input box but Safari randomly decided to slice app's drawing area (?) so this won't work either. I think I'll take Vit's advice and won't waste any more time on this, since I ran out of ideas. Hope that's ok!

Screen.Recording.2023-02-16.at.13.04.49.mov

@mountiny
Copy link
Contributor

@tjaniczek I think this makes sense. @puneetlath Should we keep this open or close this if we are confident this is related to Webkit issue which is a bit out of our control?

@puneetlath
Copy link
Contributor

Ugh, safari. Ok thank you for your investigation. I agree that it's probably best to close for now. I'm going to go ahead and close, but anyone feel free to reopen the issue if you disagree or if you think there's a solution!

@abdulrahuman5196
Copy link
Contributor

@puneetlath @mountiny I am not sure on the process here. Does the reporter of the bug(me) gets compensated on this issue as it is a valid bug though.

@puneetlath
Copy link
Contributor

In this case, no. We compensate for bugs that we decide to and are able to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

10 participants