[HOLD for payment 2023-04-13] [$4000] Can not focus on state field when clicking "fix the errors" while adding debit card Action Performed

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Goto https://staging.new.expensify.com/
2. Settings -> Payments -> Add payment method -> Debit card
3. Fill all the inputs except state
4. Click save, error message will appear as state field is blank
5. Click "fix the errors"

Expected Result:

It should highlight the state field

Actual Result:

It does not focus (highlight) on the state field

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• MacOS / Chrome / Safari

Version Number: 1.2.64-2
Reproducible in staging?: Y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-02-03.at.12.26.15.AM.mov

Recording.1438.mp4

Expensify/Expensify Issue URL:
Issue reported by: @mdneyazahmad
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675366008238219

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0170944b93cd7d941c
• Upwork Job ID: 1623018156763713536
• Last Price Increase: 2023-03-03

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[miljakljajic]

Reproducible:

[miljakljajic]

Can this be worked on externally?

[MelvinBot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[johnmlee101]

Yep!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0170944b93cd7d941c

[MelvinBot]

Current assignee @miljakljajic is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.95-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix scrolling to pickers #16433

If no regressions arise, payment will be issued on 2023-04-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat / @johnmlee101] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat / @johnmlee101] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat / @johnmlee101] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@miljakljajic] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[cubuspl42]

@parasharrajat @johnmlee101

It's been quite a ride 😃 But now as we're close to the finish line, I have a few thoughts and questions.

From the another proposal we eventually didn't use any part:

Changes should be applied to https://github.com/Expensify/react-native-picker-select

It wasn't necessary to apply much (or eventually, any) changes in react-native-picker-select

• For Android and Web forward ref of @react-native-picker/picker Picker component

That ref lacked the measureLayout method, causing inconsistent scrolling

• For IOS forward ref of Picker's TextInput component

That ref's focus method did literally nothing, leaving other text inputs focused

Are we proceeding with the split payment?

Also, the fact that we had to basically fall back, step by step, to my original proposal (because of the discovered issues), was (from my perspective) the main reason why I missed the bonus deadline.

So I would kindly ask you to reconsider the bonus assignment (even though I didn't technically have the PR merged in 3 days). Another argument for that might be that, from the beginning, I tried to help with this issue as much as I could from the external side, including GitHub and Slack discussions that, as I see it, clarified the actual scope of this issue. But this is just a kind request, I'm pushing my luck here 😄

[parasharrajat]

@cubuspl42 Thanks for bringing this up. I was going to suggest that during payment. Anyways, please try to keep these comments to be minimal required info. I noticed that you are over-detailed many times.

I agree that you were very active in this issue but the process is the same for all. So it does not qualify for a bonus. Apart from 3 days merge bonus, no additional work was done that qualifies for a bonus.

---

In short, there is no need for a payment split as we didn't use the other proposal.

Here is the new plan for compensation which invalidates the old plan.

1. @cubuspl42 full payment 4K.
2. All process rules apply to @cubuspl42.
3. No bonus as PR took more than 3 days to merge.

cc: @johnmlee101 @miljakljajic

---

[johnmlee101]

👍

[miljakljajic]

Contracts extended to all! Please accept so I can get you paid. Will we need a regression test for this?

[cubuspl42]

@miljakljajic "This offer is not available anymore"

[miljakljajic]

try now? No idea why it says that!

[cubuspl42]

@miljakljajic Now it was fine. Accepted 👍

[miljakljajic]

@parasharrajat let me know if you have any trouble with yours

[MelvinBot]

@cubuspl42, @johnmlee101, @parasharrajat, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@cubuspl42, @johnmlee101, @parasharrajat, @miljakljajic Huh... This is 4 days overdue. Who can take care of this?

[cubuspl42]

Everything is settled from my side. So I guess @parasharrajat can confirm and we can close the issue.

[parasharrajat]

I couldn't find any contracts or offers for this job. @miljakljajic Can you please check it?

[miljakljajic]

Sent a new offer @parasharrajat

[parasharrajat]

Accepted @miljakljajic

[miljakljajic]

All contributors paid, contract ended, closing.

[cubuspl42]

@miljakljajic Actually, my contract is still open

[miljakljajic]

My mistake - closed!