Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] "----------New" message removed after two replies. #15064

Closed
6 tasks done
kavimuru opened this issue Feb 10, 2023 · 21 comments
Closed
6 tasks done

[$1000] "----------New" message removed after two replies. #15064

kavimuru opened this issue Feb 10, 2023 · 21 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kavimuru
Copy link

kavimuru commented Feb 10, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open two web app send message to User A from User B
  2. open User B chat from User A you will see green line "New" message
  3. reply back to User B (green line "New" message will be removed after one reply)
  4. now send message from User B to User A again you will see green line "New" again
  5. now reply to User B from User A now this time green line "New" will removed after two replies

Expected Result

Green line "New" message should be remove after one reply

Actual Result:

"--New" message removed after two replies

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.67-2
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

2023-02-09.14-59-40-1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675938702382709?thread_ts=1675888386.030119&cid=C049HHMV9SM

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01893843251fa388df
  • Upwork Job ID: 1625905024362889216
  • Last Price Increase: 2023-02-15
@kavimuru kavimuru added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 10, 2023
@MelvinBot
Copy link

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 10, 2023
@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2023
@NicMendonca
Copy link
Contributor

@kavimuru can you please fill out the platforms check box please?

@melvin-bot melvin-bot bot removed the Overdue label Feb 13, 2023
@kavimuru
Copy link
Author

@NicMendonca I was not able to reproduce. Contributor was able to reproduce in all the platforms

@NicMendonca
Copy link
Contributor

@kavimuru okay, thanks! The contributor can still reproduce: https://expensify.slack.com/archives/C049HHMV9SM/p1676470679632749?thread_ts=1675888386.030119&cid=C049HHMV9SM

Trying on my end now!

@NicMendonca
Copy link
Contributor

I can't reproduce this:

image

@NicMendonca
Copy link
Contributor

Okay I got it actually:

My steps were:

  • User A sends User B one message
  • User B replies
  • User A sends User B two back to back messages
  • User B sees all 3 messages as "new", even though they have already seen the first message

image

@NicMendonca
Copy link
Contributor

@NicMendonca NicMendonca added External Added to denote the issue can be worked on by a contributor and removed Needs Reproduction Reproducible steps needed labels Feb 15, 2023
@melvin-bot melvin-bot bot unlocked this conversation Feb 15, 2023
@melvin-bot melvin-bot bot changed the title "----------New" message removed after two replies. [$1000] "----------New" message removed after two replies. Feb 15, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01893843251fa388df

@MelvinBot
Copy link

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 15, 2023
@MelvinBot
Copy link

Triggered auto assignment to @marcaaron (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Aaqib925

This comment was marked as off-topic.

@marcaaron
Copy link
Contributor

I'm actually not following what the issue is here. @NicMendonca that sounds like the expected behavior to me.

@marcaaron
Copy link
Contributor

I'm gonna close because the repro steps are not really making sense to me. The new line clears when I switch from one web app to the other and focus the new one. I cannot leave "two replies" and get it to clear. It's just gone when switching. That seems a bit unexpected based on the behavior established in the unread indicators doc - but feels like something we should investigate separately.

@marcaaron marcaaron closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2023
@ayazhussain79
Copy link
Contributor

@marcaaron
Copy link
Contributor

Yes, the new marker should be removed after a new comment is left by the user who can see it. Can you please re-report this with the exact steps? It looks like you are sending a message from an email. If that's part of the reproduction please be very specific, thanks!

@ayazhussain79
Copy link
Contributor

Sir im receiving message from Web Chrome App on the video should i mention you at re-report post?

@Expensify Expensify locked and limited conversation to collaborators Feb 17, 2023
@marcaaron
Copy link
Contributor

Nope - just re-report please, thanks!

@bondydaa
Copy link
Contributor

we're centralizing discussion on #15212 since we're going to try and solve all this more holistically with a design doc

@Expensify Expensify unlocked this conversation Mar 21, 2023
@MonilBhavsar
Copy link
Contributor

This should be fixed! Can we please retest and close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

9 participants