[HOLD for payment 2023-04-03] mWeb/Chrome - Send money - After several entries and deletions of numbers, the cursor disappears

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #15710

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Tap on the FAB button -> Send money
4. Enter and delete numbers several times

Expected Result:

The cursor is present

Actual Result:

After several entries and deletions of numbers, the cursor disappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.82.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5971810_Record_2023-03-10-19-14-55.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @mateocole (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@mateocole Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mateocole]

yep going to have an engineer double check to confirm this isnt intentional and something we can mark as external

[MelvinBot]

Triggered auto assignment to @PauloGasparSv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[PauloGasparSv]

Hey, I don't think I understand the problem or what the cursor is.

I opened the Android emulator and tested the "Send Money" and "Request Money" features a bit just like the evidence video but I see no problems. I also tested with the "Show Taps" option enabled in the dev setings.

@kbecciv Is the "cursor" the clicks that show if you enable "Show Touches"/"Show Taps" in the Android developer settings? I also couldn't find any problems with that enabled.

[PauloGasparSv]

Bump @kbecciv, and can you also confirm if this was reported using an emulator or an actual device?

[kbecciv]

QA team is using Actual devices always.

[PauloGasparSv]

Thksss @kbecciv, I wanted to make sure this wasn't related to the emulator and if there was a possibility this would only be reproducible in an actual device.

Can you also give me feedback on this comment?

[PauloGasparSv]

Bump @kbecciv

[kbecciv]

@PauloGasparSv Show taps option is enabled and issue is reproduced on my device SG21/13 with build 1.2.87.0

Screen_Recording_20230317_173843_Chrome.mp4

[PauloGasparSv]

Thks @kbecciv!!

I wanted to make sure because it's hard to understand what happens when the little round cursor goes to the top of the screen! It looks like you can't do anything after that happens and the cursor gets stuck on the top of the screen so I'll try to reproduce that.

I still couldn't reproduce it so maybe I'll have to ask for help in slack for someone with an android device!

[PauloGasparSv]

Not overdue!

[mountiny]

Taking this one after asking Paulo 1:1 I think its related to this change #15710

[narefyev91]

Hey, I am Nicolay from Callstack and i will check this issue

[mountiny]

@narefyev91 @PauloGasparSv and me could not reproduce this, lets close this one out, if it comes back as a problem we can reopen

[kbecciv]

When executing this PR #16340, issue is not fixed on build 1.2.88.0

Record_2023-03-21-19-00-01.mp4

[mountiny]

@kbecciv Hmm maybe whats the device you are testing on? Is it only chrome mWeb?

[kbecciv]

This is Andriod/Chrome

[mountiny]

@narefyev91 are you able to repro using Android/chrome

[narefyev91]

@mountiny @kbecciv based on the video and my test now - cursor disappeared because you click not on number pad - but somewhere in between buttons. Text input automatically loose focus (when you click outside) - in my view it's expected behaviour.

Screen.Recording.2023-03-22.at.11.54.44.mov

[mountiny]

Can we make it so the cursor appears again once you start typing again?

[narefyev91]

@mountiny yup - will prepare a PR with that fix

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Autofocus Amount field if suddenly loose focus #16394

If no regressions arise, payment will be issued on 2023-04-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

I dont this requires a regression test, and it was a regression from previous pr too so no payment is due here

[0xmiros]

The PR which fixes this issue handled only mWeb case. So another web/desktop issue was introduced which should have been caught here.
In the future, when we fix something on specific platforms, we should also take care of possible similar cases on all platforms.