Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Migrate AttachmentPicker/index.native.js to function component #16116

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 39 comments
Closed
1 task

[$250] Migrate AttachmentPicker/index.native.js to function component #16116

marcaaron opened this issue Mar 20, 2023 · 39 comments
Assignees
@sonialiap @marcaaron @JKobrynski @Santhosh-Sellavel
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01183dfbebd5805613
  • Upwork Job ID: 1688993294115909632
  • Last Price Increase: 2023-08-08
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate index.native.js to function component [HOLD][$250] Migrate index.native.js to function component Apr 13, 2023
@kuluruvineeth

This comment was marked as spam.

Sign in to view
@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 30, 2023
@MelvinBot
Copy link

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label May 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 5, 2023

Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented May 11, 2023

10 days overdue. I'm getting more depressed than Marvin.

@melvin-bot melvin-bot bot removed the Daily KSv2 label May 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 16, 2023

This issue has not been updated in over 14 days. eroding to Weekly issue.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue labels May 16, 2023
@muxriddinmuqimov77
Copy link

I'd like to work on this issue

@melvin-bot melvin-bot bot added the Overdue label Jun 6, 2023
@s-alves10
Copy link
Contributor

I'd love to work on this.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot removed the Overdue label Jun 8, 2023
@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@rayane-djouah
Copy link
Contributor

Can I work on this issue?

@mkhutornyi
Copy link
Contributor

I'd like to work on this.

@melvin-bot melvin-bot bot added the Overdue label Jul 11, 2023
@ghost
Copy link

ghost commented Jul 12, 2023

dibs?

@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue

@Habben101

This comment was marked as spam.

Sign in to view
@annscode

This comment was marked as spam.

Sign in to view
@expertscoders

This comment was marked as spam.

Sign in to view
@melvin-bot melvin-bot bot added the Overdue label Aug 10, 2023
@Santhosh-Sellavel
Copy link
Collaborator

@JKobrynski Any update?

@melvin-bot melvin-bot bot removed the Overdue label Aug 10, 2023
@JKobrynski
Copy link
Contributor

@Santhosh-Sellavel sure! Earlier today I shared a draft PR with our team for initial review, once it's done I will post it

@JKobrynski JKobrynski mentioned this issue Aug 11, 2023
Merged
59 tasks
@JKobrynski
Copy link
Contributor

JKobrynski commented Aug 11, 2023 •
edited
Loading

@Santhosh-Sellavel PR is ready for review!

@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2023
@sonialiap
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Aug 14, 2023
@JKobrynski
Copy link
Contributor

PR has been updated, remains under review

@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 22, 2023

@sonialiap, @marcaaron, @JKobrynski, @Santhosh-Sellavel Huh... This is 4 days overdue. Who can take care of this?

@Santhosh-Sellavel
Copy link
Collaborator

PR Merged and waiting for deploy!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 22, 2023
@sonialiap
Copy link
Contributor

Deployed 🚀 I believe we now wait 7 days in case of regressions

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 25, 2023
@sonialiap
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 28, 2023
@sonialiap
Copy link
Contributor

Successfully passed the staging deploy and today it's been deployed to production. I'm wrapping up my day now so I'm going to complete this tomorrow

@melvin-bot melvin-bot bot removed the Overdue label Aug 29, 2023
@sonialiap
Copy link
Contributor

@Santhosh-Sellavel review $250 - please request payment in newdot

@Santhosh-Sellavel
Copy link
Collaborator

Requested on ND

@JmillsExpensify
Copy link

$250 payment approved for @Santhosh-Sellavel based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sonialiap sonialiap

@marcaaron marcaaron

@JKobrynski JKobrynski

@Santhosh-Sellavel Santhosh-Sellavel

Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests