[Awaiting Payment][$250] Migrate BaseKYCWall.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/KYCWall/BaseKYCWall.js
  • type: React.Component
  • has state values: true
  • has refs: false
  • has context: false
  • lifecycle methods: componentDidMount,componentWillUnmount

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017c04af1c1cb9169b
• Upwork Job ID: 1709215451872694272
• Last Price Increase: 2023-10-03
• Automatic offers:
• abdulrahuman5196 | Reviewer | 27683790

Issue Owner

Current Issue Owner: @kadiealexander

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[muxriddinmuqimov77]

I'd like to work on this issue

[s-alves10]

I'd love to work on this.

[dayana7204]

I am ready to work on this ticket. :)

[olexyt]

I can work on this issue.

[rayane-djouah]

Can I work on this issue?

[mejed-alkoutaini]

I'm able to work on this if needed!

[mkhutornyi]

I'd like to work on this.

[neonbhai]

Hi, I am interested and would love to takes this when it opens up! 😀

[Swor71]

Hey, I'm Marcin from Callstack - expert contributor group - I would like to help resolve this issue

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017c04af1c1cb9169b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[ghost]

Dibs

[cooldev900]

I'd like to work on this task.

[Talha345]

I would like to work on this!

[abdulrahuman5196]

Sorry folks. I think already @Swor71 is assigned to work on this issue

[kadiealexander]

@bondydaa is it worth us putting the help wanted label back on here?

[bondydaa]

i asked in the callstack channel about the issue if they wanted to handle or send it to someone else https://expensify.slack.com/archives/C03UK30EA1Z/p1699979808984299 will wait to see what they say.

[teneeto]

Hi, I'm Eto from Callstack - expert contributor group - and I would like to take a look at this issue.

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bondydaa]

Great thank you Eto!

[teneeto]

A quick Question @bondydaa, what really happened with the reverted merged PR?

1. Was there any issues with the migration itself?
2. Or was it the merge that caused the regression?

I'm asking because I need to know, if we just need to restore the reverted merged PR or there's an issue with the migration itself that i need to look into.

[bondydaa]

The revert was b/c of a crash that was happening, let me know if you can't see this thread https://expensify.slack.com/archives/C049HHMV9SM/p1697838755135299?thread_ts=1697694190.199399&cid=C049HHMV9SM

the first part of that thread was something different starting from where Matt chimes in and posts videos is the portion that concerns why we reverted the PR.

but steps were:

I'm still getting a crash on login on staging and the PR for/from here already hit staging.

1. Log in
2. App crashes
   or... try to navigate from a report link to staging.new.expensify.com and it crashes
   or... more reliable repro steps
   from my [email protected] account, try to open [email protected] to chat with.
   Happening on Mac - Chrome and Windows - Chrome (via browserstack)

So I think it was just upon sign in.

Looks like this was initially suggested as a fix for the crash before we reverted #30109 (comment)

[teneeto]

The revert was b/c of a crash that was happening, let me know if you can't see this thread https://expensify.slack.com/archives/C049HHMV9SM/p1697838755135299?thread_ts=1697694190.199399&cid=C049HHMV9SM

the first part of that thread was something different starting from where Matt chimes in and posts videos is the portion that concerns why we reverted the PR.

but steps were:

I'm still getting a crash on login on staging and the PR for/from here already hit staging.

1. Log in
2. App crashes
   or... try to navigate from a report link to staging.new.expensify.com and it crashes
   or... more reliable repro steps
   from my [email protected] account, try to open [email protected] to chat with.
   Happening on Mac - Chrome and Windows - Chrome (via browserstack)

So I think it was just upon sign in.

Looks like this was initially suggested as a fix for the crash before we reverted #30109 (comment)

@bondydaa Thanks and I fully get the gist now. I will update, test again and then raise a PR. BTW the linked worked, Thanks.

[melvin-bot]

This issue has not been updated in over 15 days. @bondydaa, @teneeto, @abdulrahuman5196, @kadiealexander eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[bondydaa]

looks like the automation failed for this, should be in waiting for payment I think?

[bondydaa]

@abdulrahuman5196 have you gotten paid for this one yet? I think you're the only one who needs to get payment right?

[abdulrahuman5196]

Thanks @bondydaa yeah. It's due for payment.
@kadiealexander

[kadiealexander]

Paid! Sorry for missing this, thanks for flagging Bondy!