[HOLD for payment 2023-10-23] [$250] Migrate OptionRow.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/OptionRow.js
  • type: React.Component
  • has state values: true
  • has refs: true
  • has context: false
  • lifecycle methods: componentDidUpdate,shouldComponentUpdate

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01569e90e356901c93
• Upwork Job ID: 1710087030669819904
• Last Price Increase: 2023-10-06
• Automatic offers:
• s-alves10 | Contributor | 27048500

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[s-alves10]

I'd love to work on this.

[cristipaval]

@marcaaron Do you think we should close this issue given the fact that we are going to break this component down into multiple components and then gradually remove it?

[marcaaron]

I'd say if we are doing something like that then this can just remain on HOLD until the component no longer exists and we can close it then.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01569e90e356901c93

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[marcaaron]

This one still exists so 🚀

[melvin-bot]

📣 @s-alves10 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[marcaaron]

@s-alves10 Gonna assign you here since you expressed interest in the past. Hopefully you are still interested? Thanks!

[vadymbokatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

this component is class based

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

we should migrate to functional components.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @s-alves10 got assigned: 2023-10-06 00:19:01 Z
• when the PR got merged: 2023-10-11 22:05:52 UTC
• days elapsed: 3

On to the next one 🚀

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• migrate: OptionRow to function component #28977

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @s-alves10 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• migrate: OptionRow to function component #28977

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @s-alves10 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• migrate: OptionRow to function component #28977

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @s-alves10 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• migrate: OptionRow to function component #28977

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @s-alves10 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

@narefyev91, @marcaaron, @s-alves10 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[marcaaron]

Oh hmm someone needs to do the payment before we close. Adding a BZ.

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[conorpendergrast]

@marcaaron To confirm, I'm paying @s-alves10 $250 via this offer?

[marcaaron]

Yep

[conorpendergrast]

Well great. That has been done!

Payouts due:

Issue Reporter: N/A

• Contributor: $250 @s-alves10

Contributor+: @narefyev91 - contractor

Eligible for 50% #urgency bonus? No

Upwork job is here.