Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Migrate index.native.js to function component #16187

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 30 comments
Closed
1 task

[$250] Migrate index.native.js to function component #16187

marcaaron opened this issue Mar 20, 2023 · 30 comments
Assignees
@kadiealexander @Santhosh-Sellavel
Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority Reviewing Has a PR in review
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0157e58f6b76a63a6f
  • Upwork Job ID: 1691722444820840448
  • Last Price Increase: 2023-08-16
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate index.native.js to function component [HOLD][$250] Migrate index.native.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@s-alves10
Copy link
Contributor

I'd love to work on this.

@kadiealexander kadiealexander self-assigned this Jun 26, 2023
@kadiealexander kadiealexander added the Weekly KSv2 label Jun 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 5, 2023
@kadiealexander
Copy link
Contributor

I have this queued to work on, not overdue.

@melvin-bot melvin-bot bot removed the Overdue label Jul 6, 2023
@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@puneetlath puneetlath changed the title [HOLD][$250] Migrate index.native.js to function component [$250] Migrate index.native.js to function component Jul 7, 2023
@rayane-djouah
Copy link
Contributor

Can I work on this issue?

@mejed-alkoutaini
Copy link

I'm able to work on this if needed!

@melvin-bot melvin-bot bot added the Overdue label Jul 14, 2023
@ghost
Copy link

ghost commented Jul 15, 2023

Dibs

@kadiealexander
Copy link
Contributor

Hey team! I'm working on this one internally.

@melvin-bot melvin-bot bot removed the Overdue label Jul 19, 2023
@kadiealexander
Copy link
Contributor

Getting close to working on this one, just a few competing priorities to deal with first!

@code0406
Copy link
Contributor

I am available to work on this.

@melvin-bot melvin-bot bot added the Overdue label Aug 1, 2023
@kadiealexander
Copy link
Contributor

Should have a PR in soon!

@melvin-bot melvin-bot bot removed the Overdue label Aug 2, 2023
@kadiealexander kadiealexander mentioned this issue Aug 8, 2023
Closed
59 tasks
@melvin-bot melvin-bot bot added the Overdue label Aug 10, 2023
@kadiealexander kadiealexander mentioned this issue Aug 16, 2023
Closed
1 task
@melvin-bot melvin-bot bot removed the Overdue label Sep 22, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 2, 2023
@kadiealexander
Copy link
Contributor

Been OOO, iPhone VM is fixed but android is still not working, trying to get testing videos.

@melvin-bot melvin-bot bot removed the Overdue label Oct 3, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 12, 2023
@kadiealexander
Copy link
Contributor

Latest update here #24615 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Oct 17, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2023
@kadiealexander
Copy link
Contributor

Latest update here #24615 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Oct 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 6, 2023
@kadiealexander
Copy link
Contributor

Latest update here: #24615 (comment)

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Weekly KSv2 labels Nov 7, 2023
@marcaaron
Copy link
Contributor Author

Looks like this should be finished before the EOY

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Dec 6, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 6, 2023

This issue has not been updated in over 15 days. @kadiealexander, @0xmiroslav eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Dec 6, 2023
@mallenexpensify mallenexpensify added Internal Requires API changes or must be handled by Expensify staff and removed Internal Requires API changes or must be handled by Expensify staff labels Jan 24, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 24, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

@mallenexpensify
Copy link
Contributor

@Santhosh-Sellavel reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks

@kadiealexander
Copy link
Contributor

This is sitting with @MonilBhavsar for final review, so it's possible no more c+ action is needed.

@melvin-bot melvin-bot bot closed this as completed Apr 5, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 5, 2024

@kadiealexander, @Santhosh-Sellavel, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kadiealexander kadiealexander

@Santhosh-Sellavel Santhosh-Sellavel

Labels
Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority Reviewing Has a PR in review
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests