[HOLD for #37437][$2000] Pressing space 2 times . appears in display name

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to iOS settings > iPhone Settings >> General >> Keyboards > toggle on "." Shortcut
2. Open the ios mobile app or iOS Safari or Mac Desktop Chrome
3. Tap Setting > Profile
4. Tap Display Name remove name
5. Write new text and press space button 2 times and see the result (the "." shortcut doesn't work even though it's enabled)

Expected Result:

if "." shortcut is enabled, the shortcut should work when tapping the space 2 times

Actual Result:

if "." shorcut is enabled, the shortcut doesn't work when tapping the space 2 times

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.96-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

m.web.safari.mp4

ios.app.mp4

TWPP4035.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @harshad2711
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680851400066889

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0194127eb40345b2ea
• Upwork Job ID: 1646595046183731200
• Last Price Increase: 2023-04-20

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[PrashantMangukiya]

This is not issue. This is iOS keyboard specific features.

Follow this Steps to Disable It:
Go to iPhone Settings >> General >> Keyboards >>

You will see this screen, So disable "." Shortcut settings as show below, It will solve the problem.

[MelvinBot]

@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

Thanks @PrashantMangukiya! I'll reach out in the slack chat to see if we can do some more testing - https://expensify.slack.com/archives/C049HHMV9SM/p1681247093995989?thread_ts=1680851400.066889&cid=C049HHMV9SM

[Christinadobrzyn]

did some testing and updated the OP - asking for a quick review to make sure I understand correctly - https://expensify.slack.com/archives/C049HHMV9SM/p1681334171519149?thread_ts=1680851400.066889&cid=C049HHMV9SM

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0194127eb40345b2ea

[MelvinBot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[Christinadobrzyn]

Updated OP based on Slack chat - I think this can be External.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[MelvinBot]

Triggered auto assignment to @chiragsalian (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MelvinBot]

@chiragsalian, @Christinadobrzyn, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hasebsiddiqui]

facebook/react-native#27693

[Christinadobrzyn]

Looks like we're waiting on more proposals

[MelvinBot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[MelvinBot]

Upwork job price has been updated to $2000

[gedu]

Hey, I will ping today, still no news. I created another issue related with TextInput, if that one get attention I will try to mention this one, so maybe it gets some momentum again.
I will be on vacation, when I'm back I will check the situation again

[Christinadobrzyn]

Hi @gedu just checking in on this for an update - thank you!

[gedu]

Hey, no yes, I pinged less of 2 weeks ago, but no response. I will try on Discord

[gedu]

Hey, I wrote on Discord trying to call my PR attention, still no news

[mallenexpensify]

Thanks @gedu , we've def found that upstream fixes can take a while.

[gedu]

I sent another ping to the reviewer

[gedu]

Posting my PR on these thread to see if it can get some visibility: https://x.com/dan_abramov2/status/1842513065952354438

[mallenexpensify]

Also noticed @mrousavy from Margelo commented there. We work with them in case that's relevant or helpful. :)

[mrousavy]

lol, this is exactly what we talked about yesterday @hannojg.
I think we can fix this, no?

[gedu]

Seems that got some traction, the reviewer is taking a look, I will fix the conflicts and clean up a bit the code: facebook/react-native#39385 (comment)

[gedu]

I just updated the PR, solved the conflicts, tomorrow I have to fix some examples I think

[gedu]

I fixed some examples that changed after a merge conflict

[gedu]

Nick made a fix, that I think is related with mine, his handle on a more generic way, we should test if this bug is still happening after his fix, So I will close my PR

cc: @mallenexpensify @Christinadobrzyn

[AndrewGable]

So we will just have to update to the version of react native that contains this PR, right?

[gedu]

@AndrewGable yes

@Christinadobrzyn not sure what should be the next step for this issue

[mhoran]

Unfortunately this issue does not seem to be resolved with the patch in facebook/react-native#39385 (review) as reported in facebook/react-native#27693 (comment).

I may have messed something up, but I tried using patch-package to apply the patch. The patch definitely compiles, but there is no behavior change and the bug persists in New Arch.

[melvin-bot]

📣 @mhoran! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[mhoran]

With all the patches mentioned in reactwg/react-native-releases#595 (comment), this issue should be resolved once and for all. The pick request should result in these patches making their way into a future 0.76 release. In the meantime, you can apply the patches manually atop 0.76 as shown in the reproducer.

[Christinadobrzyn]

Just checking on this, I'm not sure what we should do here. @mhoran @eVoloshchak @gedu should we continue to keep this on hold for the patch?

[mhoran]

The patch landed in React Native v0.76.2. Note that the app must be moved to the New Architecture, as the fix was only implemented for New Architecture.