Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] mWeb/Chrome-Chat- Black area above the keyboard overlaps the Send button #17270

Closed
1 of 6 tasks
kbecciv opened this issue Apr 11, 2023 · 21 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Apr 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/
    and log in
  2. On a conversation, click on the + button in the compose box
  3. Click on add attachment
  4. Select password protected PDF file
  5. Tap enter the password
  6. Tap on black area under Confirm button (keyboard must be open)

Expected Result:

The keyboard should close.

Actual Result:

The black area above the keyboard overlays the "Submit" button, and the user can send a password-protected PDF file when he can't see the Submit button.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.98.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6013601_Screen_Recording_20230411_165117_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0104d35537e2d13310
  • Upwork Job ID: 1648307770535841792
  • Last Price Increase: 2023-04-25
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 11, 2023
@MelvinBot
Copy link

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Apr 11, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Apr 14, 2023
@maddylewis
Copy link
Contributor

i do not have access to an Android so I'm confirming the best next step to take in this case.

@melvin-bot melvin-bot bot removed the Overdue label Apr 14, 2023
@maddylewis
Copy link
Contributor

ive requested access to the Uploaded Apps folder in Browserstack.

https://stackoverflowteams.com/c/expensify/questions/14817

@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2023
@maddylewis
Copy link
Contributor

will complete reproduction steps today

@MelvinBot
Copy link

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@maddylewis
Copy link
Contributor

hiya @luacmartins - i think this is external, but wanted to double-check before adding that label. thanks!

@luacmartins
Copy link
Contributor

Yup. Adding the external label.

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Apr 18, 2023
@melvin-bot melvin-bot bot changed the title mWeb/Chrome-Chat- Black area above the keyboard overlaps the Send button [$1000] mWeb/Chrome-Chat- Black area above the keyboard overlaps the Send button Apr 18, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~0104d35537e2d13310

@MelvinBot
Copy link

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 18, 2023
@MelvinBot
Copy link

Current assignee @luacmartins is eligible for the External assigner, not assigning anyone new.

@s77rt
Copy link
Contributor

s77rt commented Apr 19, 2023

I can't reproduce, but there is a chance to get this fixed by #16443.

@maddylewis
Copy link
Contributor

@luacmartins - what do we think? was this potentially resolved by #16443?

@luacmartins
Copy link
Contributor

That PR hasn't been merged yet. I'd say we wait and try to reproduce this issue again once that PR is merged.

@melvin-bot melvin-bot bot added the Overdue label Apr 24, 2023
@luacmartins
Copy link
Contributor

PR is merged and on staging. @maddylewis @s77rt can either of you still reproduce the bug?

@melvin-bot melvin-bot bot removed the Overdue label Apr 24, 2023
@s77rt
Copy link
Contributor

s77rt commented Apr 24, 2023

I was never able to reproduce. Deferring to @maddylewis

@MelvinBot
Copy link

@s77rt @luacmartins @maddylewis this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@s77rt
Copy link
Contributor

s77rt commented Apr 25, 2023

@MelvinBot We are still trying to reproduce the bug.

cc @maddylewis

@MelvinBot
Copy link

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@maddylewis
Copy link
Contributor

i wasn't able to reproduce the bug so looks like #16443 fixed the issue. ill close this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants