Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-04-21 #17804

Closed
14 tasks done
OSBotify opened this issue Apr 21, 2023 · 5 comments
Closed
14 tasks done

Deploy Checklist: New Expensify 2023-04-21 #17804

OSBotify opened this issue Apr 21, 2023 · 5 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Apr 21, 2023

Release Version: 1.3.4-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mountiny
Copy link
Contributor

Checking #17717 off, its a ProductionQA

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 21, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.4-0 🚀

@mvtglobally
Copy link

Regression is completed

PR #16443 is failing #17866. Repro in prod. Checking off
PR #17327 is failing #17869. This PR is somewhat confusing. It would be great if you can re-validate it on your side.

@jasperhuangg jasperhuangg self-assigned this Apr 24, 2023
@jasperhuangg
Copy link
Contributor

@mvtglobally #17327 is unrelated to #17869. Checking it off

@jasperhuangg
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants