Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Profile - Time Zone is not updated on secondary device after changing on main device #18036

Closed
2 of 6 tasks
kbecciv opened this issue Apr 26, 2023 · 71 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented Apr 26, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go https://staging.new.expensify.com/
    and login on 2 devices
  2. Change Time Zone in profile on main device
  3. Verify Time Zone on secondary device

Expected Result:

Time Zone should be updated

Actual Result:

Time Zone is not updated

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.6.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6033250_video_69.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ad9119a009eaf79a
  • Upwork Job ID: 1651357597669793792
  • Last Price Increase: 2023-10-11
  • Automatic offers:
    • 0xmiroslav | Contributor | 26911215
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 26, 2023
@MelvinBot
Copy link

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@marcaaron
Copy link
Contributor

I don't know why we are expecting this to work in realtime, but it would require a backend change and therefore is an Internal issue. Gonna take a quick look at this and will put it back where I found it if not immediately clear...

@marcaaron marcaaron added the Internal Requires API changes or must be handled by Expensify staff label Apr 26, 2023
@marcaaron marcaaron self-assigned this Apr 26, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01ad9119a009eaf79a

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

@marcaaron
Copy link
Contributor

This works fine for me.

@marcaaron marcaaron added the Needs Reproduction Reproducible steps needed label Apr 26, 2023
@marcaaron
Copy link
Contributor

@kbecciv did we try testing on some other platform combinations to see if this is unique to Android & Windows?

@kbecciv
Copy link
Author

kbecciv commented Apr 28, 2023

@marcaaron I can request the QA team to reproduce the issue with different devices. Let me know and I will do that.

@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@marcaaron
Copy link
Contributor

Yes please, let's reopen this if we can reproduce it. I am guessing this was some kind of temporary disruption because I can't reliably reproduce.

@kbecciv
Copy link
Author

kbecciv commented May 17, 2023

QA team is able to reproduce this issue on build v1.3.15-4

second.timezone.mp4

@kbecciv kbecciv reopened this May 17, 2023
@melvin-bot melvin-bot bot added the Overdue label May 17, 2023
@conorpendergrast
Copy link
Contributor

I could reliably produce this, when changing on my OSX native client (1.3.15-0) and iOS client app (1.3.15-5). To compare, I also changed pronouns between devices (always by changing the OSX app setting first).

Changing pronouns: 20 seconds, precisely, three times
Changing the Automatically determine your location setting: within less than a second
Changing timezone: I gave up after 2 minutes, it just didn't change on the mobile app (even after I exited and re-entered the Profile page)

So, yeah, reproduced!

@melvin-bot melvin-bot bot removed the Overdue label May 17, 2023
@conorpendergrast conorpendergrast removed the Needs Reproduction Reproducible steps needed label May 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 17, 2023

@conorpendergrast @marcaaron @0xmiroslav this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@conorpendergrast
Copy link
Contributor

@marcaaron This is internal, correct?

@marcaaron
Copy link
Contributor

yeah, I am going to guess that this is related to some of the issues on staging with Pusher and multiple events stuff. I don't really have a great handle on what exactly is happening there and I'm going OOO next week so I'd probably suggest that we re-add the engineering label and get someone else to help if this is urgent.

FWIW I think the 3 week warning about WAQ is a bit unreasonable since it's only been "reopened" for 2 days.

@melvin-bot melvin-bot bot added the Overdue label May 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 27, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@0xmiros
Copy link
Contributor

0xmiros commented Sep 27, 2023

I think we don't need a C+ here either, so unassigned @0xmiroslav

#18036 (comment)

I can take this back as C+

@isabelastisser isabelastisser assigned 0xmiros and unassigned s77rt Sep 27, 2023
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 27, 2023

📣 @0xmiroslav 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@isabelastisser
Copy link
Contributor

Great, thanks @0xmiroslav !

@isabelastisser
Copy link
Contributor

We are still waiting for proposals.

@0xmiros
Copy link
Contributor

0xmiros commented Oct 2, 2023

@isabelastisser can you please remove Reviewing and add Help Wanted label?

@isabelastisser isabelastisser added Help Wanted Apply this label when an issue is open to proposals by contributors and removed Reviewing Has a PR in review labels Oct 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Oct 5, 2023
@marcaaron
Copy link
Contributor

Waiting for proposals

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 9, 2023

@isabelastisser, @marcaaron, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@marcaaron
Copy link
Contributor

@0xmiroslav please leave updates on any daily issues you are assigned to avoid them going overdue

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@0xmiros
Copy link
Contributor

0xmiros commented Oct 10, 2023

Waiting for proposals

Same ^

@melvin-bot
Copy link

melvin-bot bot commented Oct 11, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Oct 13, 2023
@0xmiros
Copy link
Contributor

0xmiros commented Oct 13, 2023

I reproduced today but not constantly reproducible

Screen.Recording.2023-10-13.at.5.10.04.PM.mov

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 13, 2023
@isabelastisser
Copy link
Contributor

@marcaaron It looks like the issue can no longer be reproduced, so I will close it now. Please feel free to reopen it if you disagree; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests