[HOLD for payment 2023-07-14] [$2000] Magic code field is flickering & doesn't allow to enter the whole code.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Sign in with email/number.
2. Try to enter the magic code.

Expected Result:

The user should be able to enter the full magic code without any flickering

Actual Result:

Magic code field is flickering & doesn't allow to enter the whole code.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.8.8
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-04-30.at.8.23.07.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @priyeshshah11
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682850385671169

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010ae7819b08b2814c
• Upwork Job ID: 1656789033045995520
• Last Price Increase: 2023-05-26

[MelvinBot]

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[arielgreen]

Cannot reproduce:

[aimane-chnaif]

@arielgreen let's keep this one open. This doesn't happen on real device but still annoying for developers as they have trouble signin on iOS simulator without any workaround.
We continue investigating this issue, though not a priority.
cc: @cristipaval @BeeMargarida

[BeeMargarida]

Just to leave a note that this only happen in iOS 16.4 simulators and the root cause is happening in all TextInputs (not only MagicCodeInput). Investigation into this was mentioned here

[tgolen]

I am reopening this because this is blocking me from developing and properly testing a new feature. We need to get this resolved ASAP.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010ae7819b08b2814c

[melvin-bot]

Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Triggered auto assignment to @alex-mechler (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[arielgreen]

Thanks for clarifying, getting a job set up.

[priyeshshah11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Magic code input doesn't work well on iOS simulators where it doesn't allow us to enter any input.

What is the root cause of that problem?

The root cause of this issue is that the RN TextInput incorrectly fires a Backspace event after every key stroke which clears the input as soon as we add it.

What changes do you think we should make in order to solve the problem?

We should debounce the onKeyPress function to ignore the backspace events if it is fired straight after (say <200ms) the actual number input event.

magic-code.mov

@s77rt @tgolen

[getusha]

I am unable to reproduce this one. anyone able to? on IOS native right?

[priyeshshah11]

I am unable to reproduce this one. anyone able to? on IOS native right?

I am able to but I think it only happens in the iOS simulator.

[getusha]

I am able to but I think it only happens in the iOS simulator.

I am testing on iOS simulator

Screen.Recording.2023-05-12.at.8.17.46.AM.mov

[priyeshshah11]

that just means that it is inconsistent, I don't know why.

[sakluger]

I've sent out contracts to @priyeshshah11 and @s77rt so that we're ready to go once the fix is merged/deployed.

[sakluger]

PR is still in review.

[sakluger]

Just checking in, is the PR ready to merge? Or are you still waiting for @mountiny's re-review?

[s77rt]

@sakluger Waiting for @mountiny I guess he is still OOO

[aimane-chnaif]

#21316 is merged but still happening to me 😞
Tested on iPhone 14 Pro - iOS 16.4 Simulator

[s77rt]

@aimane-chnaif Try clear the pods and run pod install

[BeeMargarida]

Seems to be working fine now in main after the merge. I built the pods again npx pod-install ios, uninstalled the app from the simulator and then ran the app with npm run ios

Video of iOS 16.4 simulator

Screen.Recording.2023-07-05.at.10.29.40.mov

[mountiny]

Merged, sorry I was ooo, merged.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: remove arm64 from Excluded Archs for IOS #21316

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - @priyeshshah11 (sent offer)
• Contributor that fixed the issue - expert contributor @BeeMargarida
• Contributor+ that helped on the issue and/or PR - @s77rt

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Fix foreground notification display bug #1034
• The offending PR has been commented on: Can't comment on that PR since it's locked but we have this slack thread instead https://expensify.slack.com/archives/C01GTK53T8Q/p1687333733378169
• A discussion in #expensify-bugs has been started: I don't feel this is needed. This is an edge case where a build optimisation backfired years later
• Determine if we should create a regression test for this bug: No

[sakluger]

Regarding payment, I sent an offer through Upwork to @priyeshshah11.

@s77rt are you still getting paid through Upwork or do you request through NewDot now?

[s77rt]

@sakluger Upwork.

[sakluger]

Sounds good @s77rt, just sent an offer through Upwork.

[s77rt]

@sakluger Accepted! Thanks!

[mountiny]

Will be completed soon

[sakluger]

Paid out all the contracts, thanks again everyone!