-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-08-01] [$1000] Emojis inside the reaction buttons appear far down #18751
Comments
Triggered auto assignment to @muttmuure ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Emoji is not in center of reaction button What is the root cause of that problem?In Lines 1040 to 1052 in 1d951e6
if the fontSize is 15, the actual lineHeight of emoji is 20. But we're setting the lineHeight is 24 => That makes the emoji is not in center What changes do you think we should make in order to solve the problem?update the lineHeight of emoji accordingly: if the fontSize is 15, set the lineHeight of emoji is 20. we also add paddingVertical: 2 to keep the size is the same as before
ResultIOS: Screen.Recording.2023-05-11.at.17.09.38.mov |
Job added to Upwork: https://www.upwork.com/jobs/~01d57ef93d5d7af14e |
Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
Triggered auto assignment to @grgia ( |
@tienifr, your solution didn't work for me. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Emojis inside the reaction buttons appear far down What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?We can add height to the emoji container. I've experimented with some numbers and found that to keep the current height we can add:
We change this code Lines 1004 to 1042 in dd5fbb6
To:
What alternative solutions did you explore? (Optional)I can see significant differences only on iOS, so we can make iOS-specific styling to adjust the slight difference. Since the iOS-specific code is minor, I'd prefer not to make another wrapper. We change this code Lines 1030 to 1042 in dd5fbb6
To
We can use iOS specific wrapper if required or use padding-bottom instead of marginTop, but it will make the bubble a little bit bigger |
@wildan-m, it's not an iOS specific bug and the solution doesn't look good to me. |
Maybe it's just my eyes, but I'm having trouble seeing the misalignment - the emojis look fairly properly aligned, at least on desktop and web. Are you guys just eyeballing it or using the inspector? Furthermore, the emojis come in different shapes, so I feel some are bound to look misaligned because the center used is not the visual center. Here's an image to demonstrate. The triangle on the left is perfectly aligned on both the vertical and horizontal axis, but it doesn't appear that way because its aligned about the blue dotted square's center. This is how software usually centrally positions elements. The triangle on the right is positioned about the triangle's center, so it looks optically aligned. |
@Victor-Nyagudi it seems to be a vertical misalignment rather than horizontal |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
still waiting for proposals |
@grgia @muttmuure @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Still waiting on proposals, I'm going to check on the spacing on native/ios myself |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.44-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-01. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
FWIW, I've seen that the current solution is to only adjust lineHeight. Actually, reducing the line height will also narrow down the bubble height, especially in safari (macos). Is that expected? Recording.45.2.mp4 |
Not overdue, Bump on BZ checklist @thesahindia |
It was an edge case and doesn't need a test case so we can skip the checklist |
Catching up after being OOO, I'll get to this later this week |
not overdue, hold for payment |
@muttmuure did we finalize payment? |
@grgia, I haven't requested the payment yet. @muttmuure, can you please confirm the payment on this issue so that I can send a request? |
Bump @muttmuure P.S. I have requested $1000. It was an internal PR review. |
C+ @thesahindia - $1000 |
$1,000 payment approved for @thesahindia based on comment above. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
Should be properly aligned in the center
Actual Result:
Appears closer to bottom of the bottom
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.12
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683717352716409
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: