[HOLD][$1000] Unable to edit the message when multiple messages are received

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app in android and login with user A
2. Open report of user B
3. edit any message, do not save it, if needed, you can exit the report
4. From any other device, login with user B
5. send multiple messages to user A until edited message leaves the screeen on user A device
6. On user A device, in user B report, click on edit message compose box to edit message and observe that app does not open the keyboard, does not display edit message compose box in middle and glitches out

Expected Result:

App should allow to edit the message

Actual Result:

App does not open edit message keyboard and does not allow us to edit the message if multiple messages are received while editing the message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.13.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

edit.message.glitches.out.when.multiple.msgs.recieved.mp4

az_recorder_20230511_181001.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683777332636589

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01abb91265e8834d00
• Upwork Job ID: 1656952977054523392
• Last Price Increase: 2023-05-12

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01abb91265e8834d00

[melvin-bot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Triggered auto assignment to @marcochavezf (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jeet-dhandha]

Few questions :

• Why do we keep draft message id ?
• When closing a chat why aren't they getting removed ?
• Why are we allowing multiple edits at the same time for the user ?

[mountiny]

Why are we allowing multiple edits at the same time for the user ?

This is just a design decision, its on purpose

I think this would be great issue for Callstack so asking them to take this one cc @marcochavezf

[Santhosh-Sellavel]

Waiting for proposals here.

[Piotrfj]

Hi I'm Piotr from Callstack - expert contributor group - will start investigation in this area

[melvin-bot]

📣 @Piotrfj You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[flaviadefaria]

A contributor was just assigned Melvin!

[flaviadefaria]

I'm OoO for 8 days so re-adding the BUG label, but keeping myself assigned. I'll be back at work on May 30th.

[marcochavezf]

PR still in review

[flaviadefaria]

Thanks @abekkala I'm back from OoO and taking this back from you now :)

[flaviadefaria]

@Piotrfj have you been able to address the comments in the PR?

[flaviadefaria]

@Piotrfj can you please give an update?

[Piotrfj]

@flaviadefaria I've been trying to reproduce the issue and I could not been able to do it, but then I saw that it only occurs in safari. So right now that I've reproduced it I'm working on the solution

[flaviadefaria]

Thanks! Do you think we can get this done by next week?

[Piotrfj]

@flaviadefaria Pretty sure I will finish it by the end of this week. I'm on a good way to complete it.

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[flaviadefaria]

@anmurali I'm officially no longer in the BugZero team so reassigning this as it will not close until tomorrow.

[marcochavezf]

PR still in review

[melvin-bot]

@marcochavezf, @anmurali, @Piotrfj, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

[marcochavezf]

Hi @Piotrfj, friendly bump for the linked PR

[melvin-bot]

@marcochavezf, @anmurali, @Piotrfj, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

[marcochavezf]

Putting this issue on hold per this comment #24154 (comment)

[melvin-bot]

This issue has not been updated in over 15 days. @marcochavezf, @anmurali, @Piotrfj, @Santhosh-Sellavel eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@marcochavezf, @anmurali, @Piotrfj, @Santhosh-Sellavel, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[Santhosh-Sellavel]

@anmurali Can we reopen this please?