[HOLD #20471] Mp3 audio file displays differently than video file when returning from offline mode

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome
2. Go to any chat
3. Send one video mp4 file and the second mp3 audio file
4. Go offline
5. Now click on both the files and notice that they open up in a new tab
6. Now go online
7. Wait for a few seconds
8. After the page is refreshed, notice that the video file plays without problem but the audio file shows some weird display

Expected Result:

Mp3 file should also be played or should get downloaded in a similar how video file behaves when coming back to online from the offline mode

Actual Result:

Mp3 file shows some weird display on coming back to online from the offline mode and doesn't behave the same way how video file does

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.13.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-05-12_20.51.29.mp4

Recording.598.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683904534756129

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b1830648bef2fa99
• Upwork Job ID: 1658211495048851456
• Last Price Increase: 2023-05-15

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[therealsujitk]

This is an internal issue, the Content-Type header isn't being set before sending the file. For some cases the browser is able to guess what kind of file it is loading, for other cases it needs to know how to display that data.

Additionally, it would be good to add a Content-Disposition header as well to set the file name and whether the file should be displayed in the browser or downloaded.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b1830648bef2fa99

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[maddylewis]

reviewed / repo'd / added internal label for review.

[maddylewis]

checking in about no proposals yet here - https://expensify.slack.com/archives/C049HHMV9SM/p1684441841209559?thread_ts=1683904534.756129&cid=C049HHMV9SM

[melvin-bot]

@maddylewis, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[maddylewis]

hiya @puneetlath - looking for some direction on this one so i added the eng label. I've added the internal label and bumped the original thread to try and get some proposal action, but i haven't had any luck yet. but since it's internal maybe i should've added the engineering label immediately??

[puneetlath]

@maddylewis yeah I think in that case, it makes sense to just go ahead and add the label to get an engineer assigned. I'll start looking into this further soon.

[melvin-bot]

@puneetlath @maddylewis @thesahindia this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@puneetlath, @maddylewis, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[puneetlath]

I will try to take this to the finish line next week after SNH.

[puneetlath]

I think this would actually get solved by the media player that we are adding in #20471. Going to go ahead and put it on hold for that.

[maddylewis]

still holding for this one - #20471

[maddylewis]

still holding for - #20471

[maddylewis]

i believe we are still holding for - #20471

[puneetlath]

Still on hold. @maddylewis I'm actually going to un-assign myself for now. Feel free to re-assign the engineering label once this is ready for some action.

[maddylewis]

holding/moving to monthly - #20471 (comment)

[maddylewis]

still holding