[HOLD for payment 2023-08-09] Remove type-specific avatars from rooms and threads

[shawnborton]

We currently have a mix of type-specific avatars for things like the #admins, #domains, etc rooms. However, threads just use the same icon as the workspace or the parent chat they were in.

Let's standardize and get rid of room-specific icons. All icons should either be the workspace avatar or the DM/Group chat:

Note that we'll want to add a lock icon next to the room name for private/#admins rooms. This also means we'll remove the workspace badge from the LHN as well and only show it in the chat header:

cc @JmillsExpensify @chiragsalian @MitchExpensify @grgia @stitesExpensify can one of you take this from here?

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0165c83124b93ca089
• Upwork Job ID: 1664763778988531712
• Last Price Increase: 2023-06-02

[grgia]

I got this one!

[grgia]

@shawnborton could you explain what you mean by This also means we'll remove the workspace badge from the LHN as well and only show it in the chat header:?

Are we just removing the pill entirely?

[grgia]

Also, do we want to keep the archived room one?

[grgia]

One more question- how about domain rooms?

[shawnborton]

For archived rooms, I think we just keep the name as it is with (archived)

For domain rooms, maybe we just use the default workspace avatars where we use the beginning letter of the domain?

[JmillsExpensify]

I wanted to quickly confirm that we're removing the pills entirely, right?

[shawnborton]

That's my understanding.

[grgia]

Started this one

[grgia]

Just confirming, we will be keeping the circular trash icon? @shawnborton

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0165c83124b93ca089

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

[melvin-bot]

This issue has not been updated in over 15 days. @grgia, @0xmiroslav eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[michaelhaxhiu]

Note: I'm preparing to go OOO for ~2 weeks, and need a BZ buddy to oversee this while I'm gone so that payment gets sent to @0xmiroslav. Thanks in advance for your help.

As a quick recap:

• This job is already complete
• But @0xmiroslav needs a little time to sort out some things with their personal bank
• So, I set an artificial deadline of 08/09 to remind us to check if it's ready to pay & close.
• If Miki comments before that requesting payment, you can issue it immediately because the job is done!
• No one else needs payment here.

[MitchExpensify]

Thanks @michaelhaxhiu! Reminder set to pay out on 8/9 👍

[MitchExpensify]

Hi @0xmiroslav ! Just waiting on you to accept this offer to issue you payment https://www.upwork.com/nx/wm/offer/25771950

[grgia]

Not overdue, waiting on payment finalization. Were you able to accept the offer @0xmiroslav ?

[MitchExpensify]

I believe @0xmiroslav is sorting out a payment issue on their end Internal Slack thread for reference

[michaelhaxhiu]

I'm back from OOO and can self assign this, just want to double check that it's not paid yet. Seems we are going to pay another individual on behalf of @0xmiroslav (and they'll sort it out from there). Is that right?

@0xmiroslav can you please confirm in newDot, where I DM'ed you about this?

[MitchExpensify]

Fwiw @michaelhaxhiu, I wasn't sure the best route for payment here but that seems to have been resolved based on this comment https://expensify.slack.com/archives/C01SKUP7QR0/p1692226249296529?thread_ts=1691559426.466079&cid=C01SKUP7QR0

[michaelhaxhiu]

I invited the friend of @0xmiroslav (who he told me via DM) to issue the $1k payment. Once that's accepted, I'll pay & close.

[michaelhaxhiu]

paid. closing.