[HOLD for payment 2023-10-30] Large legal name are not saved and no error message is displayed

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings
3. Open profile
4. Open personal details
5. Open legal name
6. Enter maximum length first name, last name in legal name and click on save
7. Go back twice and revisit legal name

Expected Result:

When the character limit is exceeded a counter should be displayed beneath the field in error as implemented here.

Actual Result:

App does not save large legal name and displays older saved name when we revisit the menu.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.20-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

legal.name.not.saved.for.large.name.mp4

Recording.815.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685263179032739

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Ollyws]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Legal name is not saved when over 40 characters.

What is the root cause of that problem?

When a legal name over 40 characters is submitted the backend returns InvalidParameterError
We are currently limiting the display name input length using CONST.DISPLAY_NAME.MAX_LENGTH which is 50 characters.

What changes do you think we should make in order to solve the problem?

In LegalNamePage, either change the textInput maxLength to 40 characters or change the backend to support a string up to 50 characters.

What alternative solutions did you explore? (Optional)

[dhairyasenjaliya]

@trjExpensify this can be hold in favour of #18647
Since we are handling all the limit there

[trjExpensify]

Yep, that makes sense to me. Added a hold, let's take care of it in one place consistently. 👍

[trjExpensify]

No change. Should have dropped this to weekly now it's on hold.

[trjExpensify]

No change, Joe is looking to come back to the linked issue this week: #18647 (comment)

[trjExpensify]

Joe kicked off that discussion.

[trjExpensify]

@joekaufmanexpensify where are we at with the next steps on #18647?

[joekaufmanexpensify]

I just posted an update on the slack discussion this morning!

[trjExpensify]

Awesome, thanks Joe!

[trjExpensify]

Joe is progressing the linked issue still. :)

[melvin-bot]

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[srikarparsi]

Looks good to me too, thanks!

[dukenv0307]

@fedirjh The PR is ready for review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Large legal name are not saved and no error message is displayed #29740

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment
• @dukenv0307 requires payment
• @dhanashree-sawant requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dukenv0307]

Just add a note here: The PR was approved by C+ on Oct 19 and merged on Oct 20. So this issue should be eligible for speed bonus.

[fedirjh]

BugZero Checklist:

• Link to the PR: Update display name front-end validation to match back-end #14873, The issue might be caused by a problem in the backend. It's possible that the backend was updated but the front-end was not updated to match.
• Link to comment: N/A I can't confirm if this is a bug form backend or frontend.
• Link to discussion: N/A
• Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

1. Open the app
2. Open settings
3. Open profile
4. Open personal details
5. Open legal name
6. Enter a very long name that is longer than the maximum 40 characters allowed for the first and last name in a legal name.
7. Verify that an error message appears Character limit exceeded (.../40) and we cannot save that invalid name

• Do we agree 👍 or 👎

[trjExpensify]

Thanks, @fedirjh! We have this test for legal name in personal details. I think we suggest adding to it, so I've created an issue for that.

[trjExpensify]

Moving on to confirm the payments due here:

• $750 to @dukenv0307 for the bug fix & #urgency bonus
• $750 to @fedirjh for the C+ review & #urgency bonus
• $50 to @dhanashree-sawant for the bug report

Urgency bonus applies because the issue was assigned on Oct 16th ~6pm (GMT) and approved on Oct 19th ~4pm (GMT) within the 3 days window.

Agreed? Let me know and I'll proceed with the offers.

[dhanashree-sawant]

Hi @trjExpensify, the reporting bonus will be 250$ as the issue is raised before august 30.

[trjExpensify]

Ah yes, of course. So In fact the payouts are as follows based on the prior to Aug 30th rates:

• $1500 to @dukenv0307 for the bug fix & #urgency bonus
• $1500 to @fedirjh for the C+ review & #urgency bonus (paid!)
• $250 to @dhanashree-sawant for the bug report (paid!)

[trjExpensify]

Offers have been sent to you all.

[dhanashree-sawant]

Thanks @trjExpensify, I have accepted the offer.

[trjExpensify]

Settled up with everyone, closing!