Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Android - Login - Autofill not triggered when tap on email field #20274

Closed
1 of 6 tasks
kbecciv opened this issue Jun 6, 2023 · 38 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jun 6, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open Android app
  2. Tap on Email field

Expected Result:

There's an autofill feature when focusing the email field

Actual Result:

Autofill is not triggered when user taps on email field. Autofill feature works on mWeb chrome on the same device.
(I have saved account data in Google password manager for the following domains : expensify.com ; new.expensify.com ; staging.expensify.com; staging.new.expensify.com)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.24.4

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

video_2023-06-07_17-03-20.mp4
Bug6082316_video_2023-06-06_19-10-54.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013a1ed062599e71d9
  • Upwork Job ID: 1706259828412588032
  • Last Price Increase: 2024-07-16
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@twisterdotcom
Copy link
Contributor

@kbecciv - this issue says the bug occurs on mweb (title) and Android / Chrome (body), but the video seems to show the Android Native app doesn't show the autofill option and Chrome does?

Which is correct? Does this come from a test at all?

@kbecciv
Copy link
Author

kbecciv commented Jun 7, 2023

Hey @twisterdotcom Sorry for confusion, It happened on Android app only , QA team only demonstrated the mWeb behaviour to show that the autofill is enabled on the device.
Please attached a new video, will update the original issue as well.

video_2023-06-07_17-03-20.mp4

@kbecciv kbecciv changed the title mweb - Login - Autofill not triggered when tap on email field Android - Login - Autofill not triggered when tap on email field Jun 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 9, 2023
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 12, 2023
@twisterdotcom
Copy link
Contributor

Thanks for the update, I will test today.

@melvin-bot melvin-bot bot removed the Overdue label Jun 12, 2023
@twisterdotcom
Copy link
Contributor

I have updated my Android device and apps finally. I still do not see this error:
https://drive.google.com/file/d/1j6Z1nkKbnkIkqRkjV_FyGcZhCepR__vi/view?usp=sharing

@lanitochka17
Copy link

Issue reproducible on Build 1.3.67-1 / Android

video_15.mp4

@lanitochka17 lanitochka17 reopened this Sep 11, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2023

@twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

@twisterdotcom Still overdue 6 days?! Let's take care of this!

@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2023

@twisterdotcom Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

@twisterdotcom 12 days overdue now... This issue's end is nigh!

@sophiepintoraetz sophiepintoraetz added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 25, 2023
@sophiepintoraetz sophiepintoraetz added the External Added to denote the issue can be worked on by a contributor label Sep 25, 2023
@melvin-bot melvin-bot bot changed the title Android - Login - Autofill not triggered when tap on email field [$500] Android - Login - Autofill not triggered when tap on email field Sep 25, 2023
@sophiepintoraetz
Copy link
Contributor

Given that Applause have been able to reproduce it, I am going to make this External. Though I'm not sure why this hasn't triggered the auto assigner for a C+ - was going to ask them to confirm whehter they can reproduce- @trjExpensify, just assigned you to baby sit whilst Ted is OOO.

@trjExpensify
Copy link
Contributor

So what's the verdict here, sorry?

@b4s36t4
Copy link
Contributor

b4s36t4 commented Sep 26, 2023

@trjExpensify I think as far as I see expected behavior should be same as attachment I shared Or close the issue as it might become impossible to implement.

@trjExpensify
Copy link
Contributor

Sorry if I'm being dense. Is this accurate?

  1. We are using auto-fill on Android native, insofar that it's supported in the software keyboard suggestions?
  2. On Android mWeb chrome we are using auto-fill, insofar that it's supported with an extra row above the keyboard?

If so, then we should be good to close this out.

@b4s36t4
Copy link
Contributor

b4s36t4 commented Sep 26, 2023

I think the issue is even we're using the code to support the auto fill feature, it's not working at all. Weather in web or android.

I think Twitter uses react-native for their web and mobile version both. The auto-fill (supported by browser & device level) should work just like how I have attached in the above image as a reference.

@akinwale
Copy link
Contributor

Been doing some digging on this. It looks like there's a general bug with React Native's autofill implementation on Android which is preventing this from working. I'm trying to figure out a fix.

@melvin-bot melvin-bot bot added the Overdue label Sep 28, 2023
@trjExpensify
Copy link
Contributor

That would be great!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@twisterdotcom, @trjExpensify, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@twisterdotcom
Copy link
Contributor

I'll take this back over now. @akinwale keep me posted.

@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Oct 5, 2023
@twisterdotcom
Copy link
Contributor

@akinwale I'm going to make this Weekly. If we don't find anything, then I'm going to go with the recommendation from @trjExpensify and @b4s36t4 to just close.

@melvin-bot melvin-bot bot removed the Overdue label Oct 5, 2023
@twisterdotcom twisterdotcom added Weekly KSv2 and removed Daily KSv2 labels Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 9, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2023
@twisterdotcom
Copy link
Contributor

Okay, let's close. Thanks for everyone's input here.

@lanitochka17
Copy link

lanitochka17 commented Jul 16, 2024

Issue is still reproducible on Mi11 Lite / Android 13

Screenrecorder-2024-07-16-14-03-14-298.mp4

@lanitochka17 lanitochka17 reopened this Jul 16, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@twisterdotcom
Copy link
Contributor

I think this is expected, and when you start typing an email it will prompt you: https://drive.google.com/file/d/1Bz6STrEzg20yjzPd9FogX_R-9y9JvEWx/view?usp=sharing

As discussed previously in this issue, I do not think this is an important thing to focus on fixing right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants