[HOLD for payment 2023-07-20] [$1000] DEV: console error on report screen which has task

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. go to any chat
2. click on + icon
3. select Assign task option
4. enter title and click on next button
5. click on Confirm task button which will navigates to task thread
6. go back to previous report screen which has task
7. reload page

Expected Result:

should not show console error

Actual Result:

shows console error (Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?)

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: DEV
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-15.at.11.39.38.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686809664829689

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01376acc439f64b8c7
• Upwork Job ID: 1673718992058445824
• Last Price Increase: 2023-06-27

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error is displayed when open report screen which has task.

What is the root cause of that problem?

Task is displayed using TaskPreview in report, and this component use RenderHTML for task assignee and task title.

App/src/components/ReportActionItem/TaskPreview.js

Line 62 in 820fa93

const htmlForTaskPreview = taskAssignee ? `<comment><mention-user>@${taskAssignee}</mention-user> ${taskTitle}</comment>` : `<comment>${taskTitle}</comment>`;

App/src/components/ReportActionItem/TaskPreview.js

Line 85 in 820fa93

<RenderHTML html={htmlForTaskPreview} />

RenderHTML uses MentionUserRenderer -> Tooltip -> Hoverable -> TextLink components for task assignee.

Hoverable uses ref for children in his render fucntion, but TextLink is a function component.

App/src/components/Hoverable/index.js

Lines 80 to 94 in 820fa93

	return React.cloneElement(React.Children.only(child), {
	ref: (el) => {
	this.wrapperView = el;
	// Call the original ref, if any
	const {ref} = child;
	if (_.isFunction(ref)) {
	ref(el);
	return;
	}
	if (_.isObject(ref)) {
	ref.current = el;
	}
	},

App/src/components/TextLink.js

Line 33 in 820fa93

function TextLink(props) {

So console error is displayed.

What changes do you think we should make in order to solve the problem?

We should change export default TextLink; in

App/src/components/TextLink.js

Line 79 in 820fa93

export default TextLink;

as below.

export default React.forwardRef((props, ref) => (
    <TextLink
        // eslint-disable-next-line react/jsx-props-no-spreading
        {...props}
        forwardedRef={ref}
    />
));

What alternative solutions did you explore? (Optional)

None.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[abekkala]

Hello @joelbettner! I'm not able to test on dev, can you confirm if this is reproducible? Thanks!

[joelbettner]

@abekkala I am able to reproduce on dev:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01376acc439f64b8c7

[melvin-bot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[mananjadhav]

I checked @StevenKKC’s proposal and it looks good.

To be safe I tested a few TextLinks if it affects their behavior.

@joelbettner all yours

🎀 👀 🎀 C+ reviewed.

[abekkala]

@joelbettner do you agree with @mananjadhav's suggestion to hire @StevenKKC based on their proposal?

[joelbettner]

@abekkala @mananjadhav That proposal from @StevenKKC looks good to me.

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[abekkala]

@maddylewis Reassigning for sabbatical

---

CURRENT STATUS:

• Issue reported by: @gadhiyamanan [$250]
• Assigned for Fix: @StevenKKC [$1000] +/- potential bonus/penalty
• C+: @mananjadhav [$1000] +/- potential bonus/penalty

Based on the new update, offers were already sent/created by Upwork 🎉

[StevenKKC]

@mananjadhav @joelbettner PR is ready for review.

[maddylewis]

@joelbettner is in the process of reviewing - #22007 (comment)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.39-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix console error on report screen which has task #22007

If no regressions arise, payment will be issued on 2023-07-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

We created UserMentionRenderer component deprecating in this PR. We added the Tooltip over TextLink and that should've shown the console error. Ideally this should've been handled during the Hoverable component creation itself. Hence I can't attribute this error to that PR.

Also I don't think we need a regression test for this one.

[mananjadhav]

@maddylewis this is ready for payout along with the timeline bonus. I've raised my request on NewDot. Can you help with the payout for @StevenKKC ?

[maddylewis]

payments:

• @StevenKKC - $1500 (contributor)
• @mananjadhav - $1500 (C+ - NewDot)
• gadhiyamanan - $250 (reporting)

[maddylewis]

everyone is paid 👍

[anmurali]

Approved 1500 to Manan based on #21496 (comment)