Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guides] Chats that are already read show up as unread in LHN #22603

Closed
6 tasks
kevinksullivan opened this issue Jul 11, 2023 · 18 comments
Closed
6 tasks

[Guides] Chats that are already read show up as unread in LHN #22603

kevinksullivan opened this issue Jul 11, 2023 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Needs Reproduction Reproducible steps needed

Comments

@kevinksullivan
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Select focus mode
  2. Click into an unread chat
  3. Navigate elsewhere

Expected Result:

The chat that is already read shouldn't show in LHN as unread

Actual Result:

The chat is shown as unread several seconds later

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.34-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

NewDot.Bug.mov

Slack conversation: https://expensify.slack.com/archives/C036S0BVAHH/p1688135931190779

@kevinksullivan kevinksullivan added Engineering Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Bug Something is broken. Auto assigns a BugZero manager. labels Jul 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. cc @thienlnam

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

@MariaHCD
Copy link
Contributor

MariaHCD commented Jul 12, 2023

Not able to 100% reproduce the issue in dev. But I managed to see it with:

  1. A (non-high-traffic) account on an IOU report (this is expected, the newest message was a notification that the IOU was paid)
Screen.Recording.2023-07-12.at.1.00.51.PM.mov
  1. A moderately high-traffic account (1000 chat reports with 5 report actions each):
Screen.Recording.2023-07-12.at.1.38.07.PM.mov

@MariaHCD
Copy link
Contributor

Not sure if related to #21766 because it seems happens for a non-high-traffic account in dev as well (although not 100% reproducible for me)

Seems like there are two scenarios in #focus mode:

  1. In the video attached in the OP, the user's read chats show up as unread when reloading the app
  2. In this case, the user views a chat (which should also set it as read) but it shows up as unread again after sometime

@MariaHCD
Copy link
Contributor

More discussions happening here: https://expensify.slack.com/archives/C04JD99283A/p1689202761085489

@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@MariaHCD
Copy link
Contributor

MariaHCD commented Jul 17, 2023

Update:

Next steps:

  1. Investigate how to fix the issue for contributors@
  2. Investigate if this issue affects IOU reports, this issue doesn't seem to be 100% reproducible for IOU reports.
  3. Keep an eye out if any guides report the issue again and have them follow these instructions

Co-assigning you @MonilBhavsar! Let me know if I missed anything above.

@MonilBhavsar
Copy link
Contributor

Investigate how to fix the issue for contributors@
Looks like we'll be using a new account to get ignore that condition in code

Sounds good 👍

David thinks this issue is reproducible when using same account on different devices, pointing to unreliable pusher delivery - https://expensify.slack.com/archives/C04JD99283A/p1689375389197839

@sakluger
Copy link
Contributor

@MariaHCD @MonilBhavsar - The Guide [email protected] says that this is still happening for her (Slack thread). Maybe you could use the new V0 Supportal tool to try reproducing in her account? Instructions on using the supportal tool are here: https://stackoverflowteams.com/c/expensify/questions/16975/16976

@melvin-bot melvin-bot bot added the Overdue label Jul 19, 2023
@MariaHCD
Copy link
Contributor

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 20, 2023
@MonilBhavsar
Copy link
Contributor

Discussed in slack. Guides are actually facing this issue #17316

@melvin-bot melvin-bot bot removed the Overdue label Jul 24, 2023
@zanyrenney
Copy link
Contributor

Does that mean we should close this out @MonilBhavsar ? Or combine the issues and tackle them in one?

@MonilBhavsar
Copy link
Contributor

I think we can bump the priority of this issue, as no one is experiencing it at the moment. As I mentioned above, guides are experiencing the other similar issue related to unread messages #17316

@MonilBhavsar MonilBhavsar added Needs Reproduction Reproducible steps needed Weekly KSv2 labels Jul 25, 2023
@MonilBhavsar MonilBhavsar removed the Daily KSv2 label Jul 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2023

@mananjadhav @MariaHCD @MonilBhavsar @zanyrenney this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jul 25, 2023
@zanyrenney
Copy link
Contributor

zanyrenney commented Jul 28, 2023

sorry what do you mean bump? do you mean punt or reduce the urgency to weekly? @MonilBhavsar

@melvin-bot melvin-bot bot removed the Overdue label Jul 28, 2023
@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Jul 28, 2023

Yes, I did and Melvin updated to daily again. I think we can close this GH as this issue is no longer faced by anyone. Thoughts @kevinksullivan @sakluger

@zanyrenney
Copy link
Contributor

Closing in that case, we can reopen if we get more live cases of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

6 participants