[HOLD for payment 2023-08-03] [$1000] Text 'Hidden' in Details Page does not change language when updating language to Spanish

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Action Performed:

1. Click FAB button
2. Click New Group
3. Search and select new users not interact before
4. Create group
5. Click header of group, Observe the word 'Hidden' below the display name of previously selected non-interactive users
6. Update language to Spanish
7. Click header of group again, observed 'Hidden' untranslated

Expected Result:

'Hidden' is translated correctly

Actual Result:

'Hidden' has not been translated yet

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.39-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-11.at.16.58.08.mov

Recording.3552.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689071735934159

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01af2a152b7e858fa7
• Upwork Job ID: 1679134444061982720
2023-07-12
• Automatic offers:
• | | 0
• namhihi237 | Contributor | 25718816
• namhihi237 | Reporter | 25718820

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

by: @namhihi237

Please re-state the problem that we are trying to solve in this issue.

'Hidden' is translated correctly

What is the root cause of that problem?

We are hard coding the text 'Hidden' here ReportParticipantsPage:

App/src/pages/ReportParticipantsPage.js

Lines 61 to 62 in 38890e2

	const userPersonalDetail = lodashGet(personalDetails, accountID, {displayName: personalDetails.displayName || 'Hidden', avatar: ''});
	const userLogin = Str.removeSMSDomain(userPersonalDetail.login || '') || 'Hidden';

Also, we have the same here:

App/src/libs/PersonalDetailsUtils.js

Line 23 in e5b7e3a

return displayName || defaultValue || 'Hidden';

What changes do you think we should make in order to solve the problem?

Use translate for them:

const getAllParticipants = (report, personalDetails, translate) => {
    const {participantAccountIDs} = report;
    return _.chain(participantAccountIDs)
        .map((accountID, index) => {
            const userPersonalDetail = lodashGet(personalDetails, accountID, {displayName: personalDetails.displayName || translate('common.hidden'), avatar: ''});
            const userLogin = Str.removeSMSDomain(userPersonalDetail.login || '') || translate('common.hidden');

In ReportParticipantsPage:

return displayName || defaultValue || Localize.translateLocal('common.hidden');

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01af2a152b7e858fa7

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[Talha345]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text 'Hidden' is not translated when language is updated.

What is the root cause of that problem?

The text 'Hidden' is hardcoded at various places in the codebase.

What changes do you think we should make in order to solve the problem?

Localization key 'common.hidden' should be used at these places.

What alternative solutions did you explore? (Optional)

None

[NicMendonca]

@sobitneupane can you please review these proposals 🙏 seems like a simple change that we can implement asap

[sobitneupane]

Thanks for the proposal @namhihi237.

First things first, why are we showing Hidden instead of email. I believe the issue here is not showing email.

[namhihi237]

@sobitneupane as far as i know here if user A hasn't chatted with user B before then we wont show login info. That's why it's how hidden here. as the video report can show

[sobitneupane]

Thanks @namhihi237. I have started a discussion on slack to confirm if it is expected to show "Hidden".

[sobitneupane]

It turns out that it is expected to show "Hidden".

Proposal by @namhihi237 looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @chiragsalian, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[namhihi237]

hi @sobitneupane @NicMendonca can assign this task for me

[NicMendonca]

@chiragsalian all good to assign here?

[namhihi237]

Hi, team any update here

[melvin-bot]

@chiragsalian, @NicMendonca, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 @sobitneupane Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @namhihi237 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @namhihi237 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[namhihi237]

Hi @sobitneupane @grgia The PR is already for review. please take a look. Thanks

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix translate hidden #23482

If no regressions arise, payment will be issued on 2023-08-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @sobitneupane does not require payment (Eligable for Manual Requests)
• @namhihi237 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[NicMendonca]

• reporter: @namhihi237 $250
• contributor: @namhihi237 $1500
• C+: @sobitneupane $1500

[NicMendonca]

@sobitneupane bump on the BZ checklist, and don't forget to request payment in Expensify!

[NicMendonca]

@namhihi237 you've been paid! 🎉

[NicMendonca]

@sobitneupane bump

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#20328

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#20328 (comment)

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

It should have been caught in PR review.

• [@sobitneupane] Determine if we should create a regression test for this bug.

I don't think specific regression test is required for the issue as it should be covered by language translation tests.

[sobitneupane]

Requested payment on newDot.

#22659 (comment)

[NicMendonca]

Thank you!!

Payment summary: #22659 (comment)

[JmillsExpensify]

Reviewed the payment details for @sobitneupane. $1,500 is approved for payment in NewDot.