Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting C+ payment - $500] [HOLD for payment 2023-08-16] Implement the MapboxAccessTokenManager #22701

Closed
neil-marcellini opened this issue Jul 11, 2023 · 27 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@neil-marcellini
Copy link
Contributor

neil-marcellini commented Jul 11, 2023

Please follow the plan in the design doc. Be sure to write a manual or automated test to make sure it gets the token properly.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012e60fd48447acbeb
  • Upwork Job ID: 1707369473068421120
  • Last Price Increase: 2023-09-28
@melvin-bot
Copy link

melvin-bot bot commented Jul 17, 2023

Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Jul 17, 2023
@luacmartins
Copy link
Contributor

I can pick up this one since it's on hold for the issue I'm working on and is related to that code.

@melvin-bot melvin-bot bot removed the Overdue label Jul 17, 2023
@luacmartins luacmartins self-assigned this Jul 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2023

Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Jul 21, 2023
@tgolen tgolen assigned tgolen and unassigned luacmartins Jul 24, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jul 24, 2023
@tgolen
Copy link
Contributor

tgolen commented Jul 24, 2023

I'm gonna start working on this since it looks like nothing has been done yet and Carlos is OOO today.

@tgolen
Copy link
Contributor

tgolen commented Jul 26, 2023

still on hold

@melvin-bot melvin-bot bot removed the Overdue label Jul 26, 2023
@tgolen
Copy link
Contributor

tgolen commented Jul 27, 2023

still on hold while deploys happen

@neil-marcellini neil-marcellini changed the title [HOLD Expensify 299168] Implement the MapboxAccessTokenManager Implement the MapboxAccessTokenManager Jul 27, 2023
@neil-marcellini
Copy link
Contributor Author

The API was deployed to staging so it's off hold now!

@tgolen
Copy link
Contributor

tgolen commented Jul 28, 2023

OK, the PR is all written and just needs to be tested and reviewed. I'll get that done today.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 28, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 9, 2023
@melvin-bot melvin-bot bot changed the title Implement the MapboxAccessTokenManager [HOLD for payment 2023-08-16] Implement the MapboxAccessTokenManager Aug 9, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 28, 2023
@michaelhaxhiu
Copy link
Contributor

@sobitneupane let's get you paid

@michaelhaxhiu michaelhaxhiu added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Sep 28, 2023
@michaelhaxhiu
Copy link
Contributor

Based on timestamps, @sobitneupane should get a $1000 flat rate for C+ review.

You are paid via newDot, can you please request payment and link this comment to the request appropriately?

@michaelhaxhiu
Copy link
Contributor

Let us know when it's done and we'll close this GH.

@Expensify Expensify deleted a comment from melvin-bot bot Sep 28, 2023
@michaelhaxhiu michaelhaxhiu changed the title [$500] [HOLD for payment 2023-08-16] Implement the MapboxAccessTokenManager [Awaiting C+ payment - $500] [HOLD for payment 2023-08-16] Implement the MapboxAccessTokenManager Sep 28, 2023
@michaelhaxhiu michaelhaxhiu removed their assignment Sep 28, 2023
@michaelhaxhiu michaelhaxhiu added NewFeature Something to build that is a new item. and removed NewFeature Something to build that is a new item. labels Sep 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 28, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 28, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Sep 28, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Sep 28, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Sep 28, 2023
@michaelhaxhiu
Copy link
Contributor

I'm re-assigning this to another BZ as part of my preparation for Sabbatical (starting Friday).

Next steps:

  • Wait for @sobitneupane to request payment via NewDot
  • After that's confirmed, close this GH 🎬

@sophiepintoraetz
Copy link
Contributor

sophiepintoraetz commented Sep 29, 2023

FYI - reviews are $500, not $1000 @michaelhaxhiu

@situchan
Copy link
Contributor

This work was done long time ago, before price drop announcement.
So original base price $1000 applies here.
PR: #23511

@sophiepintoraetz
Copy link
Contributor

Ahk, that context was missing. Thanks for the update @situchan!

@sobitneupane
Copy link
Contributor

I think @situchan was the one who reviewed the PR, not me.

@sobitneupane sobitneupane removed their assignment Oct 2, 2023
@sophiepintoraetz
Copy link
Contributor

Thanks for the honesty and correcting Hax there! Waiting on @situchan to request $1000 on ND for the PR review. I'm going to go ahead and close this, seeing as that's the only outstanding action.

cc @JmillsExpensify

@situchan
Copy link
Contributor

situchan commented Oct 2, 2023

@sophiepintoraetz sorry, I am still using upwork

@sophiepintoraetz
Copy link
Contributor

Okay, offer sent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants