Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-01] [ECARD] CRITICAL: Settings - Update UI to show fraud states #22881

Closed
grgia opened this issue Jul 14, 2023 · 37 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 ECard Wave5-free-submitters Internal Requires API changes or must be handled by Expensify staff

Comments

@grgia
Copy link
Contributor

grgia commented Jul 14, 2023

HOLD ON https://github.com/Expensify/Expensify/issues/299929

Design Doc Section

https://docs.google.com/document/d/1rFxJ78vz5On6zSWzYa51B9v-tyLdC5pUsBeLOLig0t4/edit#bookmark=id.1i6m8he8e79j

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b0834be89a7c4cf5
  • Upwork Job ID: 1679792329644658688
  • Last Price Increase: 2023-07-14
@grgia grgia added the Internal Requires API changes or must be handled by Expensify staff label Jul 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b0834be89a7c4cf5

@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jul 17, 2023
@joekaufmanexpensify joekaufmanexpensify changed the title [HOLD E/E#299929][ECard Settings] - Update UI to show fraud states [ECard Settings] - Update UI to show fraud states Aug 30, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 30, 2023
@joekaufmanexpensify
Copy link
Contributor

Off hold as https://github.com/Expensify/Expensify/issues/299929 was just closed today!

@joekaufmanexpensify joekaufmanexpensify added Daily KSv2 and removed Monthly KSv2 labels Aug 30, 2023
@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2023
@grgia
Copy link
Contributor Author

grgia commented Aug 31, 2023

cc @pac-guerreiro

@pac-guerreiro
Copy link
Contributor

Could you assign me to this @grgia ? 😄

@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2023

@eVoloshchak Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Sep 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@eVoloshchak, @pac-guerreiro 10 days overdue. I'm getting more depressed than Marvin.

1 similar comment
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@eVoloshchak, @pac-guerreiro 10 days overdue. I'm getting more depressed than Marvin.

@pasyukevich
Copy link
Member

Hi!
I'm Eugene from Callstack, an expert contributor group.
I'd like to work on this.

@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

@eVoloshchak, @pasyukevich Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2023
@pasyukevich
Copy link
Member

Work in progress. This issue is connected with #22873

@melvin-bot melvin-bot bot removed the Overdue label Sep 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2023

@eVoloshchak, @pasyukevich Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

@eVoloshchak, @pasyukevich Still overdue 6 days?! Let's take care of this!

@grgia grgia self-assigned this Sep 27, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 25, 2023
@melvin-bot melvin-bot bot changed the title [ECard Settings] - Update UI to show fraud states [HOLD for payment 2023-11-01] [ECard Settings] - Update UI to show fraud states Oct 25, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.90-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 1, 2023
Copy link

melvin-bot bot commented Nov 6, 2023

@eVoloshchak, @pasyukevich, @grgia, @JKobrynski Huh... This is 4 days overdue. Who can take care of this?

@eVoloshchak
Copy link
Contributor

@joekaufmanexpensify, could you post a payment summary so I can request the payment for this?
I think it's the only action left in order to close this one

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2023
@joekaufmanexpensify
Copy link
Contributor

Yep! Only payment needed here is $500 to @eVoloshchak for C+ review. Paid via NewDot.

@dylanexpensify dylanexpensify changed the title [HOLD for payment 2023-11-01] [ECard Settings] - Update UI to show fraud states [HOLD for payment 2023-11-01] [ECARD] CRITICAL: Settings - Update UI to show fraud states Nov 7, 2023
@dylanexpensify dylanexpensify added the ECard Wave5-free-submitters label Nov 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 9, 2023
@grgia
Copy link
Contributor Author

grgia commented Nov 9, 2023

Can we close this out @eVoloshchak

@melvin-bot melvin-bot bot removed the Overdue label Nov 9, 2023
@eVoloshchak
Copy link
Contributor

@grgia, yes, this one can be closed

@melvin-bot melvin-bot bot added the Overdue label Nov 13, 2023
Copy link

melvin-bot bot commented Nov 13, 2023

@eVoloshchak, @pasyukevich, @grgia, @JKobrynski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Nov 13, 2023

@eVoloshchak, @pasyukevich, @grgia, @JKobrynski Whoops! This issue is 2 days overdue. Let's get this updated quick!

1 similar comment
Copy link

melvin-bot bot commented Nov 13, 2023

@eVoloshchak, @pasyukevich, @grgia, @JKobrynski Whoops! This issue is 2 days overdue. Let's get this updated quick!

@JmillsExpensify
Copy link

$500 payment approved for @eVoloshchak based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 ECard Wave5-free-submitters Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Development

No branches or pull requests

8 participants