[$1000] mWeb - Long pressing assignee of task not working properly

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click FAB -> Assign task
2. Add task details -> Select assignee
3. Long press on Assignee of task (Which is highlighted)

Expected Result:

It show open proper page when opened in new tab

Actual Result:

It shows "Hmm... it's not here" when opened assignee in new tab

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.40-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

IMG_7822.MOV

IMG_7823.MOV

Expensify/Expensify Issue URL:
Issue reported by: @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689340118378199

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e03d9b2126b6eabd
• Upwork Job ID: 1681650265478438912
• Last Price Increase: 2023-09-27
• Automatic offers:
• abdulrahuman5196 | Contributor | 26933751
• DinalJivani | Reporter | 26933753
• ShogunFire | Contributor | 26983720

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

The videos are incorrect?

[DinalJivani]

Yes @samh-nl these are wrong videos..!
CC: @kbecciv

[huzaifa-99]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want the <TextLink/> of the MentionUserRenderer.js to open in a new tab on long press (which is the expected behaviour of <TextLink/>)

What is the root cause of that problem?

We are using relative link in MentionUserRenderer.js, when we open this link in a new window, report route prefix /r is appended which breaks the Url.

What changes do you think we should make in order to solve the problem?

In MentionUserRenderer.js, add a / before the route to make it absolute

href={'/' + ROUTES.getDetailsRoute(loginWithoutLeadingAt)} // or via string literal

Optionally we can create a util to convert relative path to absolute path.

What alternative solutions did you explore? (Optional)

N/A

[laurenreidexpensify]

@DinalJivani are the videos correct now?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e03d9b2126b6eabd

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[DinalJivani]

@DinalJivani are the videos correct now?

No not yet below are correct videos by @kbecciv

IMG_7822.MOV

IMG_7823.MOV

[ShogunFire]

@kbecciv Can you confirm the expected behaviour on long press ? For other links it looks like we open the context menu, and on web when we right click (which is often the equivalent of long press) we open the context menu

[ShogunFire]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When we long press an assignee it doesn't show the context menu and opens a page instead

What is the root cause of that problem?

In the PressableWithoutFeedback in TaskPreview here:

App/src/components/ReportActionItem/TaskPreview.js

Lines 75 to 80 in e098992

	<PressableWithoutFeedback
	onPress={() => Navigation.navigate(ROUTES.getReportRoute(props.taskReportID))}
	style={[styles.flexRow, styles.justifyContentBetween]}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
	accessibilityLabel={props.translate('task.task')}
	>

We don't handle the long press event, like we do in IOUPreview or ReportPreview

What changes do you think we should make in order to solve the problem?

We should handle the long press event in TaskPreview.
For that we need to pass the right props from ReportActionItem here:

App/src/pages/home/report/ReportActionItem.js

Lines 282 to 286 in e098992

	<TaskPreview
	taskReportID={props.action.originalMessage.taskReportID.toString()}
	action={props.action}
	isHovered={hovered}
	/>

The right props are

chatReportID={props.report.reportID}
contextMenuAnchor={popoverAnchorRef}
checkIfContextMenuActive={toggleContextMenuFromActiveReportAction}

then in TaskPreview we just need to pass the long press handler to the Pressable:
onLongPress={(event) => showContextMenuForReport(event, props.contextMenuAnchor, props.chatReportID, props.action, props.checkIfContextMenuActive)}

Result:

2023-07-21.16-28-55.mp4

What alternative solutions did you explore? (Optional)

Here is my branch if you want to try:
https://github.com/ShogunFire/App/tree/longPressForTaskPreviews

[laurenreidexpensify]

Thanks @DinalJivani - have updated issue with correct videos

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abdulrahuman5196]

Will work on review today.

[laurenreidexpensify]

@abdulrahuman5196 bump for review ^^ thanks

[abdulrahuman5196]

Sorry for the delay - Reviewing today

[abdulrahuman5196]

Pending review from @AndrewGable

[melvin-bot]

📣 @ShogunFire 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[laurenreidexpensify]

@DinalJivani will issue correct $250 payment when everything is issued

[abdulrahuman5196]

Gentle Ping @AndrewGable

[ShogunFire]

@abdulrahuman5196 I think he already assigned me, sorry I was on a trek. I will do the PR today

[abdulrahuman5196]

OOPS. Sorry I didn't see that. My bad.

[AndrewGable]

No worries - Hope the trek was fun 🥾!

[melvin-bot]

This issue has not been updated in over 15 days. @AndrewGable, @ShogunFire, @abdulrahuman5196, @laurenreidexpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[ShogunFire]

@abdulrahuman5196 The PR is ready for review

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Its not regression. But it existed this way from beginning.

Determine if we should create a regression test for this bug.

Yes

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Click FAB -> Assign task
2. Add task details
3. Select assignee
4. Long press on Assignee of task
5. Verify that the context menu shows on platforms with touch screen

@laurenreidexpensify
Seems melvin didn't update here automatically. The issue is for payment due today - #28840 (comment)

[ShogunFire]

Can someone makes the paiement for this ?

[abdulrahuman5196]

@laurenreidexpensify Could you kindly process payment on this? Pending for sometime.

[laurenreidexpensify]

Sorry for the delay here everyone - the automation fail meant I failed to pick this up in time.

Payment Summary:

• Bug report: @DinalJivani $250 (old rates, reported before 24 Oct) - payment issued in Upwork
• Contributor: @ShogunFire $1000, offer sent in Upwork
• C+: @abdulrahuman5196 $1000, payment issued in Upwork

[laurenreidexpensify]

@ShogunFire - https://www.upwork.com/en-gb/jobs/~01e5ffccb028936763

[laurenreidexpensify]

Outstanding action to close: Pay @ShogunFire once job is accepted in Upwork

[laurenreidexpensify]

Updated Payment Summary:

Contributor: @ShogunFire $1000, paid in Upwork