Deploy Checklist: New Expensify 2023-07-17 #23033
Comments
mvtglobally
added
the
🔐 LockCashDeploys 🔐
|
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.42-0 🚀 |
|
If I already QAed the PR I was assigned for the previous Deploy Checklist, do I need to again? Is there a possibility it's broken now? Not sure on the process (or what happened here to have it show up again) |
|
@dangrous I accidentally deployed the old checklist during the stress test, but cancelled that deploy. So your PR was checked off, and in the process of being deployed, but didn't actually get deployed. So it was included in this checklist again. I would QA it again just to be sure that it still works with the new items in this checklist. Sorry for the hassle! |
|
@jasperhuangg similar question. Should we re-QA ALL of the PRs from previous checklist as well? |
|
ah @mvtglobally I didn't think about this.. yes, I think it's best, otherwise regressions might get through. Thanks for asking. |
|
@jasperhuangg As a heads up - this will increase the result turnaround time considerably since it's another 30 PRs to verify. We will keep you posted on the progress. |
|
@isagoico that's fine, thanks for letting me know! |
|
@Julesssss @jasperhuangg I see the build is upped. Can you pls share the CPs we need to test as I dont see them in checklist |
|
Checking #23083 off, not a blocker. @mvtglobally I think if you have verified some PRs yesterday in the checklist, I dont think we have to be verifying them again, any reason for that @jasperhuangg? |
|
Confirmed #22590 works well! |
|
@aimane-chnaif Yep, the CP failed https://github.com/Expensify/App/actions/runs/5588876019/jobs/10216344982 trying to get that resolved All good, its deployed |
@mountiny I'm concerned that a new combination of PRs may cause regressions/blockers that we weren't previously aware of. I'd rather catch those bugs now rather than later. |
|
Checking off #23050 as it isn't reproducible in the latest release and shouldn't be a blocker |
|
We are working on the full list Will be sharing update shortly |
|
Checking off blocker 23106, not an issue |
|
Checking off #17452, was able to QA this myself successfully |
|
Checking off #23102 since we CP'd a fix to staging. |
|
@mvtglobally I tested #17452 myself and it works as expected, gonna remove it from your list |
|
Current summary #22830 CP pending validation on all platforms |
|
Checked them off! |
|
sorry for the long summary @jasperhuangg but I wanted to provide the actual feedback on all unchecked so we have a better visibility |
|
QA'd #22243 successfully myself, checking it off |
|
QA'd #22755 successfully myself, checking it off |
|
QA'd #22734 successfully myself, checking it off |
|
Checking off #23077 repro in prod |
|
We CP'd a fix for #23123, just retested on staging and it works now, checking it off |
|
Current summary #22830 CP pending validation on all platforms |
|
QA'd #23107 myself and it works, checking it off |
|
Cherry-picked this minor PR to staging and checked it off: #23155 |
|
@jasperhuangg Regression is completed Final summary |
|
|
Release Version:
1.3.42-26Compare Changes: production...staging
This release contains changes from the following pull requests:
index.ios.jsto function component #22529index.android.jsto function component #22542report.ownerEmails that slipped through or were recently added #22559report.participantswith*.participantAccountIDs(Pt 1) #22639Internal QA:
Deploy Blockers:
Deployer verifications:
cc @Expensify/applauseleads
The text was updated successfully, but these errors were encountered: